Fix service fee query #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Feb 18, 2025
Contributor
fhenneke
left a comment
fhenneke
left a comment
There was a problem hiding this comment.
The change looks fine.
The previous behavior makes more sense to me. It only does not work due to using names for determining joining dates. This seems like one more reason to just hard-code values instead of maintaining that query.
Contributor
Author
Actually you are right. The previous version is the most reasonable in terms of interpreting the CIP and this "fix" just works because of the given situation of the existing solvers. Will rethink a bit more about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query assumed, implicitly (this was not really intended), that every colocated solver with a reduced pool had initially joined the CoW DAO bonding pool at least 3 months before creating the reduced pool. This caused some issues, with Portus, for example. This is a bug, and this PR adds an explicit check so as to ensure that solvers that joined the CoW DAO bonding pool AND created a subpool within an interval of 3 months will start paying a service fee after 3 months. Specifically for Portus, there is no ambiguity around this as they joined a long time ago and only got renamed (which revealed the issue in the first place)