Skip to content

Check explicitly for order type in classified fees #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Check explicitly for order type in classified fees #283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
447fa5a
check explicitly for order type
fhenneke Nov 13, 2025
e5adc72
disable parsing error due to type cast
fhenneke Nov 13, 2025
3ae29da
slight change to ordering
fhenneke Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cowprotocol/accounting/fees/classified_fees_4058574.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ with raw_fee_data as (
atoms_sold,
atoms_bought,
sell_token_address,
order_type,
protocol_fee,
surplus_fee,
network_fee,
Expand Down Expand Up @@ -51,10 +52,11 @@ network_fees as (
tx_hash,
order_uid,
sell_token_address as token_address,
coalesce(
-- PRS disabled: int256 is not standard Trino, only available in Dune
coalesce( -- noqa: PRS
network_fee,
case
when sell_token_address = protocol_fee_token_address then surplus_fee - protocol_fee
when order_type = 'BUY' then surplus_fee - protocol_fee
else surplus_fee - cast(1.0 * protocol_fee * (atoms_sold - surplus_fee) / atoms_bought as int256)
end,
0
Expand Down