Exclude KMS account client from the Debug impl #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR customizes the Debug implementation for the KMS Account struct to exclude the verbose client field output while retaining debug information for key_id and address fields.
- Replaces the derived Debug trait with a custom implementation
- Excludes the client field from debug output to reduce verbosity
- Maintains debug information for key_id and address fields
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jmg-duarte
approved these changes
Sep 23, 2025
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
LGTM, sad that Rust doesn't have something like #[debug(skip)] because for longer structs this would be kind of annoying to implement
MartinquaXD
approved these changes
Sep 24, 2025
Contributor
@jmg-duarte, it's not built in but this can be done with the derivative crate (see here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMS account client's debug information is too verbose, which is not useful. The proposal is to exclude this from the Debug impl entirely.