-
Notifications
You must be signed in to change notification settings - Fork 0
feat: open position wrapper #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* check solver on internalSettle function * check only callable through EVC * prevent reentrancy
make settlement the gatekeeper why did I not do this before
This reverts commit e56eac3.
best way to ensure the expected flow is followed exactly
* check solver on internalSettle function * check only callable through EVC * prevent reentrancy
they shouldn't have been in the repository
feat: use new wrapper from upstream
feat: working security
we use the settlement contract, so it shouldn't be needed anymore also soljson.latest is still here
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
src/CowEvcBaseWrapper.sol
Outdated
| /// @dev By default we return the default value (empty array, false) | ||
| /// @param location The memory storage position where the parameters needed to encode the batch items have been saved | ||
| /// @return items Array of batch items to execute | ||
| /// @return needsPermit Whether these items require user signature or prior authorization as an operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the parameter name and explanation is confusing to me. The permission it needs is more specific than the text suggests.
Same comment in _encodeBatchItemsAfter
| /// @return needsPermit Whether these items require user signature or prior authorization as an operator | |
| /// @return canUsePermit Whether the returned batch items are intended to be optionally executed in an EVC permit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The permission it needs is more specific than the text suggests.
Hmm, in a general sense, the flag is intended to indicate whether the things returned require some sort of special permissions. The way that those permissions can be obtained varies (either setAccountOperator or EVC.permit), of course, So I thought needsPermit was an overall good . Would needsPermission be better indication of such a thing? I just want to confirm exactly a label that makes sense to both of us before I go in and rename everything again 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also I prefer th ecomment as it exists right now. The new comment in your suggestion makes it sound like the authorization from the user is somehow optional, but its not.
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
Description
Implements the
CowEvcOpenPositionWrapperin order to satisfy a usecase for the Euler integration.Context
Read up on notion
Considerations
collateralAmountto 0)Out of Scope
Every line of code in this PR should be considered in-scope.
Testing Instructions
Follow the test command instructions in the README
We want to make sure:
fixes https://linear.app/cowswap/issue/COW-65/initial-merge-contract-of-cowevcopenpositionwrapper