chore: remove CoW lib #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we barely depend on this library now with the all-in-one CowWrapper file, and accidental usages of this library often lead to bugs due identical implementations in different places. So to prevent this, no more CoW lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
cowdependency (CoW core protocol contracts).Context
We barely depended on this library pior to this PR in the tests only, with the all-in-one
CowWrapper.solfile, and accidental usages of this library often lead to bugs due identical implementations in different places. So to prevent this, no more CoW lib.Testing Instructions
Use the README to run the tests and verify they are succeeding same as before.
verify that the gitsubmodule is being removed and there are no more traces of it throughout the repo.