Add Claude Code GitHub Workflow #3731
Conversation
| PART 2 - CODE REVIEW: | ||
|
|
||
| REVIEW FOCUS (issues only, no positive feedback): | ||
| 1. **Bugs & Logic Errors**: Race conditions, off-by-one errors, incorrect error handling, panic risks |
There was a problem hiding this comment.
Add possible deadlocks (such as holding a regular mutex over an await), unexpected drops (like the request id issue)
There was a problem hiding this comment.
Yeah, I think deadlocks as a category would be helpful.
| REVIEW FOCUS (issues only, no positive feedback): | ||
| 1. **Bugs & Logic Errors**: Race conditions, off-by-one errors, incorrect error handling, panic risks | ||
| 2. **Non-Idiomatic Rust**: Unnecessary clones, missing iterators, improper lifetimes, unwrap() abuse | ||
| 3. **Style Deviations**: Check CLAUDE.md for project conventions (alloy vs ethcontract patterns, RPC batching, quote system) |
There was a problem hiding this comment.
Btw alloy has a "base" prompt, should we add it or something?
| 1. **Bugs & Logic Errors**: Race conditions, off-by-one errors, incorrect error handling, panic risks | ||
| 2. **Non-Idiomatic Rust**: Unnecessary clones, missing iterators, improper lifetimes, unwrap() abuse | ||
| 3. **Style Deviations**: Check CLAUDE.md for project conventions (alloy vs ethcontract patterns, RPC batching, quote system) | ||
| 4. **Test Coverage**: Missing tests for new functionality, edge cases not covered |
There was a problem hiding this comment.
Maybe tell him to suggest tests too instead of just flagging
| PR AUTHOR: ${{ github.event.pull_request.user.login }} | ||
| PR TITLE: ${{ github.event.pull_request.title }} | ||
|
|
||
| You are a Rust code reviewer for the CoW Protocol services codebase. |
There was a problem hiding this comment.
Does the "experience Rust code reviewer with background in ..." still help?
There was a problem hiding this comment.
It should. Reassuring AI agents leads to measurably better results.
|
|
||
| TASK: | ||
| 1. Generate a PR description if the PR body is empty | ||
| 2. Review the PR diff and leave inline comments on problematic code |
There was a problem hiding this comment.
I've had success telling him to review and sumarize first, do a todo list and then start working, could that be helpful here?
|
|
||
| jobs: | ||
| claude-review: | ||
| if: github.event.pull_request.user.login == 'squadgazzz' |
There was a problem hiding this comment.
This should be removed to allow everyone's PR to be reviewed
| [How these changes should be tested. If no new tests were added, write "Existing tests"] | ||
|
|
||
| ## Related issues | ||
| <!-- Link related issues here, e.g., Fixes #123 --> |
There was a problem hiding this comment.
Should we allow gh pr list and gh issue list, for Claude to access other PR's so they can be referenced here more easily?
|
@m-sz @jmg-duarte let's avoid wasting anyone's time by reviewing draft PRs. This one is not even close to being ready for review. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
🤖 Installing Claude Code GitHub App
This PR adds a GitHub Actions workflow that enables Claude Code integration in our repository.
What is Claude Code?
Claude Code is an AI coding agent that can help with:
How it works
Once this PR is merged, we'll be able to interact with Claude by mentioning @claude in a pull request or issue comment.
Once the workflow is triggered, Claude will analyze the comment and surrounding context, and execute on the request in a GitHub action.
Important Notes
Security
There's more information in the Claude Code action repo.
After merging this PR, let's try mentioning @claude in a comment on any PR to get started!