Add prometheus to playground #3752
Merged
+73
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fafk
reviewed
Oct 8, 2025
| ports: | ||
| - 8080:80 | ||
| - 8080:80 # API | ||
| - 9586:9586 # metrics |
Contributor
There was a problem hiding this comment.
Does the port need to be exposed? 🤔
Contributor
Author
There was a problem hiding this comment.
Yes, the orderbook and autopilot expose the metrics on a separate port. In the driver and baseline solver we use the one port that also handles the regular API requests. 😅
fafk
approved these changes
Oct 8, 2025
m-sz
reviewed
Oct 8, 2025
m-sz
approved these changes
Oct 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the playground's
grafanacontainer is only there to supporttempobut you can't actually test any new metrics or queries with it. This PR makes it so thatgrafanaactually gets access to all the metrics.Changes
metricsports on containers where it's necessaryprometheuscontainer that scrapes all the services podsprometheusas the default data source ingrafanaHow to test
I manually checked that
grafanagets access to metrics from all the different pods and I built a new dashboard with it.As a follow up we could consider somehow replicating our actual dashboards but that goes beyond the scope of the PR (and probably isn't that helpful anyway because the metrics reported by a locally running instance are very far from what our actual deployments would look like).