Skip to content

[EASY] Drop auction_orders and auction_participants tables in DB #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 20, 2025
Merged

[EASY] Drop auction_orders and auction_participants tables in DB #3753

merged 7 commits into from
Oct 20, 2025
+5 −0

Conversation

@squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Oct 8, 2025 •
edited
Loading

Actually drops the table from the DB. More details can be found in previous PRs: #3751, #3766. Must be released separately from the mentioned PRs.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
If creating new tables, update the tables list.
When adding a new index, consider using CREATE INDEX CONCURRENTLY for tables involved in the critical execution path.

Caused by:

@squadgazzz squadgazzz mentioned this pull request Oct 10, 2025
Merged
@squadgazzz squadgazzz changed the title Drop auction_orders table in DB Drop auction_orders and auction_participants tables in DB Oct 10, 2025
squadgazzz added a commit that referenced this pull request Oct 10, 2025
@squadgazzz
Migrate from auction_participans to proposed_solutions table (#3766)
a532c61 
# Description
The `auction_participans` table has become obsolete, since the same data
is now stored in the `proposed_solutions`. This PR migrates usage to the
latter table. The migration script will be a part of #3753, since this
is a breaking change, which requires gradual deployment to avoid panics
when running 2 auctions in parallel.
xdecentralix pushed a commit to xdecentralix/services that referenced this pull request Oct 10, 2025
@squadgazzz @xdecentralix
Migrate from auction_participans to proposed_solutions table (cow…
0af1ae7 
…protocol#3766)

# Description
The `auction_participans` table has become obsolete, since the same data
is now stored in the `proposed_solutions`. This PR migrates usage to the
latter table. The migration script will be a part of cowprotocol#3753, since this
is a breaking change, which requires gradual deployment to avoid panics
when running 2 auctions in parallel.
@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).

  • If creating new tables, update the tables list.
  • When adding a new index, consider using CREATE INDEX CONCURRENTLY for tables involved in the critical execution path.
  • For breaking changes, remember that during rollout k8s starts the new autopilot, runs the Flyway migration, and only then shuts down the old pod. That overlap means the previous version can still be processing requests on the migrated schema, so make it compatible first and ship the breaking DB change in the following release.

Caused by:

@squadgazzz squadgazzz marked this pull request as ready for review October 16, 2025 09:05
@squadgazzz squadgazzz requested a review from a team as a code owner October 16, 2025 09:05
Copilot AI review requested due to automatic review settings October 16, 2025 09:05
Copilot AI reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a database migration to drop the auction_orders and auction_participants tables from the database, completing the cleanup work started in previous PRs #3751 and #3766.

Key changes:

  • Adds a new database migration script to permanently remove auction-related tables
  • Uses conditional DROP statements to safely handle cases where tables may not exist

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@squadgazzz
Copy link
Contributor Author

squadgazzz commented Oct 16, 2025 •
edited
Loading

It should be safe to merge since the code migration was released in https://github.com/cowprotocol/services/releases/tag/v2.331.0

@squadgazzz squadgazzz changed the title Drop auction_orders and auction_participants tables in DB [EASY] Drop auction_orders and auction_participants tables in DB Oct 16, 2025
@squadgazzz squadgazzz enabled auto-merge (squash) October 16, 2025 09:08
@squadgazzz squadgazzz merged commit 3547e42 into main Oct 20, 2025
25 of 28 checks passed
@squadgazzz squadgazzz deleted the flyway/drop-auction-orders-table branch October 20, 2025 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jmg-duarte jmg-duarte jmg-duarte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@squadgazzz @jmg-duarte