Skip to content

Update DB reminder readme #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

Update DB reminder readme #3765

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7493975
Update DB reminder readme
squadgazzz Oct 9, 2025
fa983f1
Phrasing
squadgazzz Oct 10, 2025
991b00c
Merge branch 'main' into db-reminder-update
squadgazzz Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/nitpicks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
- markdown: |
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
If creating new tables, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87).
When adding a new index, consider using `CREATE INDEX CONCURRENTLY` for tables involved in the critical execution path.
* If creating new tables, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87).
* When adding a new index, consider using `CREATE INDEX CONCURRENTLY` for tables involved in the critical execution path.
* For breaking changes, remember that during rollout k8s starts the new autopilot, runs the Flyway migration, and only then shuts down the old pod. That overlap means the previous version can still be processing requests on the migrated schema, so make it compatible first and ship the breaking DB change in the following release.
pathFilter:
- "database/sql/**"

Expand Down
Loading