refactor(e2e): use alloy bindings and primitives in liquidity_source_notification test #3788
Conversation
squadgazzz
left a comment
squadgazzz
left a comment
There was a problem hiding this comment.
Thank you for your contribution. I suppose half of the work alloy should have done automatically already and it can be used in this PR.
Also, could you later look into this issue? #3748
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
markin-io
force-pushed
the
refactor/e2e/liquorice_api_alloy_bindings
branch
from
34e6ffd to
1db7ec5
Compare
squadgazzz
left a comment
squadgazzz
left a comment
There was a problem hiding this comment.
Thanks a lot, it looks much better now! 🤩
Just a few nits.
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
Just have one question, everything else looks ok
| ) | ||
| .manual( | ||
| "ILiquoriceSettlement", | ||
| "LiquoriceSettlement", |
There was a problem hiding this comment.
Why the replacement between the interface and the contract?
There was a problem hiding this comment.
Because of the hashSingleOrder function of the contract that used in the e2e test.
The function is not available in the interface since it belongs to the Signing contract that only LiquoriceSettlement extends.
3 participants
Description
A follow up to #3735 (comment)
Changes
Refactored test code to use alloy contract bindings and primitives
How to test
$ FORK_URL_MAINNET="...." cargo test -p e2e forked_node_liquidity_source_notification_mainnet -- --ignored