Replace readiness probe with startup for autopilot #3856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fafk
approved these changes
Nov 3, 2025
Contributor
|
LGTM, I think it's exactly as discussed. Approved, just pls add a PR description. 🤠 |
m-sz
force-pushed
the
autopilot-startup-probe
branch
4 times, most recently
from
dc878bb to
93786e0
Compare
jmg-duarte
reviewed
Nov 4, 2025
Contributor
Author
|
I have done some test deployments on sepolia and here are my findings: Tests done on sepolia-staging
10 auctions average auction-to-auction: 12s Which shows that the fix is working as expected. |
jmg-duarte
reviewed
Nov 4, 2025
Contributor
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
Reads much better, some nits
fafk
reviewed
Nov 4, 2025
Contributor
Author
|
Updates PR based on comments, will re-test on staging to sign off. |
This reverts commit 0235ec9.
Co-authored-by: José Duarte <[email protected]>
Co-authored-by: José Duarte <[email protected]>
Co-authored-by: José Duarte <[email protected]>
Co-authored-by: José Duarte <[email protected]>
m-sz
force-pushed
the
autopilot-startup-probe
branch
from
eabe512 to
b5d1ea4
Compare
Co-authored-by: ilya <[email protected]>
Contributor
Author
|
Latest timings Looks like the latest revision is also working as expected. Merging the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The zero downtime deployment for autopilot requires the newly created one to warm up its caches before the previous one can step down and leadership be transferred. Previous implementation reported readiness after taking over and the readiness probe was not used, making this mechanism fail to work.
Changes
Remove the usage of readiness probe in autopilot. Introduce startup probe. Signal startup finished once caches become warmed up, regardless of leader lock status.
How to test