Migrate driver::util::math into alloy #3880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
commented
Nov 6, 2025
Contributor
Author
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
Notes for reviewers:
squadgazzz
reviewed
Nov 6, 2025
squadgazzz
reviewed
Nov 6, 2025
squadgazzz
reviewed
Nov 7, 2025
m-sz
reviewed
Nov 7, 2025
squadgazzz
approved these changes
Nov 7, 2025
Contributor
squadgazzz
left a comment
squadgazzz
left a comment
There was a problem hiding this comment.
LGTM
try_info -> custom operation, check the most significant limbs after U256 for overflow and return None if they're not 0 (i.e. overflow happened)
This is not true anymore, right?
Contributor
Author
Updated, good catch |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
# Description Migrate driver::util::math into alloy The replacement of U256s implies that we no longer have the same operations available and need to implement some by hand. Notes on operations: * full_mul -> widening_mul (kudos @squadgazzz) # Changes - [ ] Migrate driver::util::math into alloy - [ ] Refactors where applicable - [ ] Adds unit tests ## How to test N/A
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate driver::util::math into alloy
The replacement of U256s implies that we no longer have the same operations available and need to implement some by hand.
Notes on operations:
Changes
How to test
N/A