Migrate get_total_surplus_endpoint to alloy #3886
Merged
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
changed the base branch from
main
to
jmgd/alloy/get_token_metadata
squadgazzz
approved these changes
Nov 7, 2025
m-sz
reviewed
Nov 10, 2025
Comment on lines
-98
to
+99
| let surplus = fetch_total_surplus(&mut ex, &ByteArray(user.0)).await?; | ||
| Ok(U256::from_f64_lossy(surplus)) | ||
| let surplus = fetch_total_surplus(&mut ex, &ByteArray(user.0.0)).await?; | ||
| Ok(U256::from(surplus)) |
Contributor
There was a problem hiding this comment.
Can You provide more information backing this is a drop-in replacement? I looked around alloy's docs but couldn't untangle it.
Contributor
Author
There was a problem hiding this comment.
use alloy::primitives::U256;
fn main() {
let mut buffer = vec![0; 32];
ethcontract::U256::from_f64_lossy(3.3).to_big_endian(&mut buffer);
assert_eq!(U256::from(3.3f64).to_be_bytes_vec(), buffer);
println!(
"{} {}",
U256::from(3.3f64),
ethcontract::U256::from_f64_lossy(3.3)
);
}
I think that in ethcontract they explicitly state that the conversion is lossy because you're bound to lose decimals, in alloy they make it implicit because you shouldn't really expect the decimals to keep when converting to an integer type.
Hope this helps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate get_total_surplus_endpoint to alloy
Changes
How to test
Existing tests