Migrate Balancer V2 from ethcontract to alloy primitives #4002

AryanGodara · 2025-12-22T04:42:11Z

Description

Migrate the balancer V2

Changes

Replace ethcontract::primitives with alloy::primitives across crates:
- driver/src/boundary/liquidity/balancerv2
- shares/sources/balancerv2
- solvers/src/liquidity/balancerv2
- solvers/src/boundary/liquidity
Remove the now redundant intoalloy and intolegacy adapters.

How to test

cargo check -p e2e --tests
Run e2e tests

github-actions · 2025-12-30T00:10:08Z

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

AryanGodara · 2026-01-06T10:37:19Z

/gemini review

gemini-code-assist

Code Review

This pull request is a significant refactoring to migrate from ethcontract primitives to alloy primitives. The changes are extensive but mostly mechanical, and you've done a great job handling the API differences between the two libraries. My review focuses on a few areas where the new alloy types have different behavior, particularly in test helper functions and debug implementations, which could be improved for correctness and clarity. I've also suggested a small simplification for parsing a large constant. Overall, this is a solid piece of work.

crates/shared/src/sources/balancer_v2/swap/fixed_point.rs

crates/shared/src/sources/balancer_v2/swap/fixed_point/logexpmath.rs

crates/shared/src/sources/balancer_v2/swap/stable_math.rs

gemini-code-assist

Code Review

This pull request migrates Balancer V2 code from ethcontract primitives to alloy primitives. The changes are extensive and mostly mechanical, replacing types like U256 and removing conversion traits. The code is generally cleaner and more consistent after these changes. I've found a few places where the removal of conversion adapters seems incomplete, leaving verbose and explicit calls to traits that are meant to be removed. My review comments focus on these inconsistencies to fully align the code with the PR's goal.

crates/shared/src/sources/balancer_v2/pools/common.rs

crates/shared/src/sources/balancer_v2/pools/stable.rs

crates/solvers/src/boundary/liquidity/stable.rs

crates/solvers/src/boundary/liquidity/weighted_product.rs

jmg-duarte

There are some things that need to be addressed before merging, I'd prefer keeping the code as close to the original as possible since (AFAIK) this is already a port from a smart contract of sorts

jmg-duarte · 2026-01-06T13:18:51Z

crates/shared/src/sources/balancer_v2/pools/common.rs


        Ok(PoolInfo {
-            id: pool_id,
+            id: H256(pool_id.0),


Should've changed to B256. but my PR changes this, so it's ok for now

crates/shared/src/sources/balancer_v2/pools/common.rs

crates/shared/src/sources/balancer_v2/pools/stable.rs

crates/shared/src/sources/balancer_v2/swap/fixed_point/logexpmath.rs

crates/shared/src/sources/balancer_v2/swap/fixed_point.rs

crates/shared/src/sources/balancer_v2/swap/stable_math.rs

crates/shared/src/sources/balancer_v2/pools/common.rs

crates/shared/src/sources/balancer_v2/swap/fixed_point/logexpmath.rs

crates/shared/src/sources/balancer_v2/swap/fixed_point.rs

Removes unnecessary type conversions between ethcontract and alloy types in Balancer V2 pool code. The conversions are no longer needed as the codebase migrates to native alloy types. Updates affected areas: - Remove IntoAlloy/IntoLegacy trait usage for U256, addresses, and pool data - Convert ethcontract::U256 to alloy::primitives::U256 in tests and implementations - Simplify type conversions in stable, weighted, composable stable, and liquidity bootstrapping pools Signed-off-by: Aryan Godara <[email protected]>

- Replace lossy unwrap_or fallbacks with direct unwrap() in Bfp Debug impl - Fix to_f64_lossy() to use string parsing for accurate large value conversion - Update test helper functions to use string-based U256/f64 conversions instead of lossy casts - Simplify into_legacy() calls by using method syntax instead of fully qualified paths

jmg-duarte

I have nits (some qualified paths and U256::from(1)) but I'll fix them in my PR

Please address the suggestion I left and IMO it's good to go

jmg-duarte · 2026-01-07T12:25:47Z

crates/shared/src/sources/balancer_v2/swap/stable_math.rs

    fn invariant_two_tokens_ok() {
        let amp = 100.;
-        let amplification_parameter = U256::from_f64_lossy(amp * AMP_PRECISION.to_f64_lossy());
+        let amplification_parameter = u256_from_f64_lossy(amp * f64::from(*AMP_PRECISION));


and on the other usages

Suggested change

let amplification_parameter = u256_from_f64_lossy(amp * f64::from(*AMP_PRECISION));

let amplification_parameter = U256::from(amp * f64::from(*AMP_PRECISION));

Oh, I fixed f64:from , but missed the other one, fixed now, pushing

- Replace all calls with direct U256::from() conversions for amplification parameter

squadgazzz

G2G as is

squadgazzz · 2026-01-07T13:47:51Z

crates/shared/src/sources/balancer_v2/pools/stable.rs


        assert_eq!(
-            AmplificationParameter::try_new(1.into(), 0.into())
+            AmplificationParameter::try_new(U256::from(1u64), U256::from(0u64))


Suggested change

AmplificationParameter::try_new(U256::from(1u64), U256::from(0u64))

AmplificationParameter::try_new(U256::ONE, U256::ZERO)

Will fix this on my PR

AryanGodara self-assigned this Dec 22, 2025

github-actions bot added the stale label Dec 30, 2025

github-actions bot closed this Jan 6, 2026

AryanGodara reopened this Jan 6, 2026

AryanGodara force-pushed the aryan/migrate-balancer-v2-to-alloy-primitives branch from d3722e9 to b164ff1 Compare January 6, 2026 09:46

AryanGodara marked this pull request as ready for review January 6, 2026 10:36

AryanGodara requested a review from a team as a code owner January 6, 2026 10:36

AryanGodara removed the stale label Jan 6, 2026

gemini-code-assist bot reviewed Jan 6, 2026

View reviewed changes

jmg-duarte mentioned this pull request Jan 6, 2026

Migrate balancer v2 sources to alloy #4023

Merged

6 tasks

jmg-duarte reviewed Jan 6, 2026

View reviewed changes

squadgazzz reviewed Jan 6, 2026

View reviewed changes

AryanGodara added 4 commits January 7, 2026 17:18

chore: remove unnecessary closure, fix clippy warning

0a8f1ec

address PR comments

2d3185d

AryanGodara force-pushed the aryan/migrate-balancer-v2-to-alloy-primitives branch from 70985b3 to 2d3185d Compare January 7, 2026 12:12

AryanGodara requested review from jmg-duarte and squadgazzz January 7, 2026 12:18

jmg-duarte reviewed Jan 7, 2026

View reviewed changes

Remove u256_from_f64_lossy() helper function that was no longer needed

a08aef1

- Replace all calls with direct U256::from() conversions for amplification parameter

jmg-duarte approved these changes Jan 7, 2026

View reviewed changes

squadgazzz reviewed Jan 7, 2026

View reviewed changes

squadgazzz approved these changes Jan 7, 2026

View reviewed changes

AryanGodara added this pull request to the merge queue Jan 7, 2026

Merged via the queue into main with commit ef94b8d Jan 7, 2026
19 checks passed

AryanGodara deleted the aryan/migrate-balancer-v2-to-alloy-primitives branch January 7, 2026 14:03

github-actions bot locked and limited conversation to collaborators Jan 7, 2026

	let amplification_parameter = u256_from_f64_lossy(amp * f64::from(*AMP_PRECISION));
	let amplification_parameter = U256::from(amp * f64::from(*AMP_PRECISION));

	AmplificationParameter::try_new(U256::from(1u64), U256::from(0u64))
	AmplificationParameter::try_new(U256::ONE, U256::ZERO)

Migrate Balancer V2 from ethcontract to alloy primitives #4002

Migrate Balancer V2 from ethcontract to alloy primitives #4002

Conversation

AryanGodara commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

How to test

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

AryanGodara commented Jan 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmg-duarte left a comment

Choose a reason for hiding this comment

Uh oh!

jmg-duarte Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmg-duarte left a comment

Choose a reason for hiding this comment

Uh oh!

jmg-duarte Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

AryanGodara Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

squadgazzz left a comment

Choose a reason for hiding this comment

Uh oh!

squadgazzz Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

jmg-duarte Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AryanGodara commented Dec 22, 2025 •

edited

Loading