-
Notifications
You must be signed in to change notification settings - Fork 151
Rename Participant to Bid #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @squadgazzz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant refactoring by renaming the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request renames the Participant struct to Bid across the codebase, primarily within the autopilot crate's domain/competition module and its related files (bid.rs, mod.rs, winner_selection.rs). This change includes updating struct definitions, impl blocks, type aliases, function signatures, variable names, and doc comments to reflect the new Bid terminology. The winner-selection/src/state.rs file also had its documentation adjusted to remove references to 'participant'. A review comment specifically suggested renaming the solutions parameter to bids and the closure variable s to b in the filter_winners test helper function for consistency with the new Bid naming convention.
m-sz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Follows a suggestion from another PR, that basically renames the Participant struct into Bid, which makes more sense since this Bid now contains the score data.
Changes
How to test
Existing tests.