Use large cluster for slippage execution #321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
commented
Jul 25, 2023
gentrexha
approved these changes
Jul 26, 2023
gentrexha
left a comment
gentrexha
left a comment
There was a problem hiding this comment.
Left a discussion comment. Other than that, LGTM.
| self, | ||
| query: Query, | ||
| job_id: Optional[str] = None, | ||
| performance: str = "medium", |
There was a problem hiding this comment.
In my opinion since this is business critical we should be defaulting to large. What do you think?
Suggested change
| performance: str = "medium", | |
| performance: str = "large", |
Contributor
Author
There was a problem hiding this comment.
Yes I like it. In that case we can set the default performance when instantiating the client. I'll move the parameter to the appropriate place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes execution faster and less likely to queue.