feat(bnb): add native token logo #1140
Conversation
WalkthroughA new JSON asset file was added at src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/info.json with empty object content. No existing files or code were modified, and there are no changes to public APIs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/logo.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/info.json(1 hunks)
🔇 Additional comments (3)
src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/info.json (3)
1-1: Logo licensing/attribution.Confirm we have rights to use the BNB logo and add attribution if this repo requires it (some info.json files include attribution/links).
1-1: Logo present — info.json is empty.src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee contains logo.png; info.json is {}. Populate info.json with the token metadata (name, symbol, decimals, description/website) and add an SVG logo (logo.svg preferred); keep logo.png as a fallback.
Likely an incorrect or invalid review comment.
1-1: ```shell
#!/bin/bash
set -euo pipefail
echo "=== occurrences of 0xeeee (case-insensitive) ==="
rg -n --hidden -S -i '0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee' || trueecho
echo "=== references to public/images ==="
rg -n --hidden -S 'public/images' || trueecho
echo "=== references to images/56/0x (likely token images) ==="
rg -n --hidden -S 'images/56/0x' || trueecho
echo "=== chainId .* 56 nearby (patterns) ==="
rg -nP --hidden -S 'chainId.{0,40}56' || trueecho
echo "=== token image resolver candidates (get.*logo|get.*image|token.*logo) ==="
rg -n --hidden -S -e 'get.*logo' -e 'get.*image' -e 'token.*logo' -e 'token.*image' || trueecho
echo "=== cat info.json under src/public/images/56/0xeeee... ==="
cat src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/info.json || trueecho
echo "=== list all 0xeeee... dirs (repeat) ==="
fd '0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee' src/public/images -t d -x sh -lc 'echo DIR={}; ls -1 {} || true' || true</blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
| @@ -0,0 +1 @@ | |||
| {} No newline at end of file | |||
There was a problem hiding this comment.
🧩 Analysis chain
Empty info.json won’t convey any metadata and likely fails repo conventions. Populate or drop.
Provide at least the common fields used elsewhere in this repo (name/symbol/links/etc.). Until we confirm the exact schema, here’s a safe minimal scaffold you can adjust to match observed keys:
-{}
+{
+ "name": "BNB",
+ "symbol": "BNB"
+}Run the script below to discover the typical keys used across existing image info.json files in this repo and align accordingly.
🏁 Script executed:
#!/bin/bash
# Inspect existing info.json keys to infer the expected schema
set -euo pipefail
if ! command -v fd >/dev/null; then echo "Please install fd-find (fd)"; exit 1; fi
if ! command -v jq >/dev/null; then echo "Please install jq"; exit 1; fi
fd info.json src/public/images | while read -r f; do
echo "--- $f"
jq -r 'keys_unsorted[]?' "$f" 2>/dev/null || true
done | awk 'NF' | sort | uniq -c | sort -nrLength of output: 24322
Populate info.json with repo-standard token metadata
File: src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/info.json is empty ({}). Repo scan shows most info.json include logoURI, chainId, address (211 files) and name, symbol, decimals (183 files); reason/removed appear for deprecations. Replace {} with at minimum: name, symbol, decimals, chainId, address, logoURI — add removed: true and reason when appropriate.
🤖 Prompt for AI Agents
In src/public/images/56/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/info.json
(lines 1-1) the file is empty; replace the empty object with a token metadata
object containing at minimum: name, symbol, decimals (numeric), chainId (56),
address (the contract address matching the folder name 0xeeee...eeee), and
logoURI (pointing to the token logo in this folder or an appropriate CDN path);
if the token is deprecated add removed: true and a reason string. Follow the
format and field names used by other files in src/public/images/56 (ensure
proper JSON types and values and that address checksum/format matches repo
convention).
Summary
Add BNB native token (0xeee...) logo
Summary by CodeRabbit