-
Notifications
You must be signed in to change notification settings - Fork 29
[addToken] PZL to MAINNET
#1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[addToken] PZL to MAINNET
#1257
Conversation
WalkthroughThis pull request adds support for the Staked PUZZLE (PZL) token to the CowSwap token list on Ethereum mainnet. The changes include registering the new token in the main token list configuration and creating a corresponding metadata file with token details. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/public/CowSwap.json (1)
382-389: Address case inconsistency between metadata and list files.The PZL token address differs in case between files:
info.json(line 3):0x37f3eD0186AaDF2966BD75cf702aD0f31AB13318(mixed case/EIP-55)CowSwap.json(line 383):0x37f3ed0186aadf2966bd75cf702ad0f31ab13318(lowercase)While Ethereum addresses are case-insensitive, maintaining consistent formatting across the repository improves maintainability. Consider standardizing to one format (EIP-55 checksum or lowercase) across all token references.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/public/images/1/0x37f3ed0186aadf2966bd75cf702ad0f31ab13318/logo.pngis excluded by!**/*.png
📒 Files selected for processing (2)
src/public/CowSwap.json(2 hunks)src/public/images/1/0x37f3ed0186aadf2966bd75cf702ad0f31ab13318/info.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: avivkeller
Repo: cowprotocol/token-lists PR: 1047
File: scripts/processRequest.mjs:38-44
Timestamp: 2025-08-04T17:57:56.851Z
Learning: In the cowprotocol/token-lists repository, the `{0}` placeholder in `prImageUrl` within `scripts/processRequest.mjs` is intentionally left as a literal template string that gets formatted/replaced when injected into comment bodies in the GitHub workflow, following the established pattern from the original `.github/workflows/processRequest.yml`.
Learnt from: avivkeller
Repo: cowprotocol/token-lists PR: 1047
File: scripts/processRequest.mjs:38-44
Timestamp: 2025-08-04T17:57:56.851Z
Learning: In the cowprotocol/token-lists repository, URLs with `{0}` placeholders in `scripts/processRequest.mjs` (like `prImageUrl`) are intentionally left as templates that get processed using GitHub Actions' `format()` function in the workflow files, where `{0}` gets replaced with operation-specific values like 'addToken' or 'addImage'.
📚 Learning: 2025-08-04T17:57:56.851Z
Learnt from: avivkeller
Repo: cowprotocol/token-lists PR: 1047
File: scripts/processRequest.mjs:38-44
Timestamp: 2025-08-04T17:57:56.851Z
Learning: In the cowprotocol/token-lists repository, the `{0}` placeholder in `prImageUrl` within `scripts/processRequest.mjs` is intentionally left as a literal template string that gets formatted/replaced when injected into comment bodies in the GitHub workflow, following the established pattern from the original `.github/workflows/processRequest.yml`.
Applied to files:
src/public/CowSwap.json
🔇 Additional comments (2)
src/public/CowSwap.json (2)
380-397: Correct placement and valid token entry structure.The PZL token entry is correctly positioned in ascending address order (between gtcETH and SAND) and includes all required fields (address, symbol, name, decimals, chainId, logoURI). The JSON syntax is valid with proper comma placement. Token details align with PR objectives: symbol PZL, name "Staked PUZZLE", decimals 18, and chainId 1 (Ethereum mainnet).
1-2087: Logo file verified—no action required.The logo image file exists at the referenced path
src/public/images/1/0x37f3ed0186aadf2966bd75cf702ad0f31ab13318/logo.png. The PR changes are complete and correct.
addToken
Note This is an automated PR
Submitted by @vlzhr
Closes #1256
Adding token
PZLon networkMAINNETAddress:
0x37f3ed0186aadf2966bd75cf702ad0f31ab13318Link to block explorer ↗︎
Reason
Summary by CodeRabbit