chore: update @cowprotocol/permit-utils
#943
Conversation
WalkthroughThe Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(1 hunks)
| "dependencies": { | ||
| "@cowprotocol/cow-sdk": "^5.11.0-RC.0", | ||
| "@cowprotocol/permit-utils": "^0.4.0", | ||
| "@cowprotocol/permit-utils": "^0.7.0-RC.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify integration of the new RC release
You’ve upgraded @cowprotocol/permit-utils to ^0.7.0-RC.0. Please ensure that:
- Any breaking changes in the RC are handled in your code (check the library’s CHANGELOG or migration guide).
- All import sites and API calls still compile and behave as expected.
- Your lockfile (
yarn.lockorpackage-lock.json) has been updated and committed alongside this bump.
Run this script to confirm lockfile updates and locate all import sites for manual review:
🏁 Script executed:
#!/bin/bash
# 1) Check for updated lockfile
if ! git diff --name-only | grep -E 'yarn.lock|package-lock.json'; then
echo "ERROR: No lockfile changes detected—please run npm/yarn install and commit the lockfile."
exit 1
fi
# 2) List all references to permit-utils for API validation
rg -n "@cowprotocol/permit-utils" --glob "src/**/*"Length of output: 258
Action Required: Commit Updated Lockfile & Verify API Usage
The RC bump for @cowprotocol/permit-utils was applied in package.json but no lockfile changes were detected. Please address the following before merging:
• package.json (line 44): You’ve upgraded to ^0.7.0-RC.0.
– Review the library’s CHANGELOG or migration guide for any breaking changes.
• Lockfile: Run npm install or yarn install and commit the resulting package-lock.json or yarn.lock.
• Import sites & API calls: Locate all references and confirm compatibility by running:
rg -n "@cowprotocol/permit-utils" --glob "src/**/*"🤖 Prompt for AI Agents
In package.json at line 44, you have upgraded @cowprotocol/permit-utils to
^0.7.0-RC.0 but have not updated the lockfile. To fix this, run npm install or
yarn install to update the lockfile (package-lock.json or yarn.lock), then
commit the updated lockfile alongside this package.json change. Additionally,
review the library’s CHANGELOG or migration guide for any breaking changes and
verify all import sites and API calls referencing @cowprotocol/permit-utils
still compile and behave correctly.
There was a problem hiding this comment.
one of the files of this PR is literally yarn.lock!
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check what files are changed in this PR
git diff --name-only HEAD~1 HEAD
echo "---"
# Also check if yarn.lock exists and was modified
git diff --stat HEAD~1 HEAD
Length of output: 453
🏁 Script executed:
#!/bin/bash
# Check what files are in the repository and look for yarn.lock
ls -la | grep -E "(yarn.lock|package-lock.json)"
echo "---"
# Check git status to see what files exist
git status --porcelain
echo "---"
# List all files that might be related to this PR
fd -t f yarn.lock
fd -t f package-lock.json
echo "---"
# Check if there are any recent commits and what files they modified
git log --oneline -5
Length of output: 239
🏁 Script executed:
#!/bin/bash
# Check if yarn.lock contains the updated permit-utils version
grep -A 2 -B 2 "@cowprotocol/permit-utils" yarn.lock
echo "---"
# Check the last modification time and see recent git activity
stat yarn.lock
echo "---"
# See if we can get any info about recent changes to yarn.lock
git log --oneline -3 --follow yarn.lock
Length of output: 543
@cowdan You're absolutely right, and I apologize for the error! 🤦♀️
I can now see that yarn.lock is indeed present and contains the updated @cowprotocol/permit-utils@^0.7.0-RC.0 entry:
"@cowprotocol/permit-utils@^0.7.0-RC.0":
version "0.7.0-RC.0"
resolved "https://registry.yarnpkg.com/@cowprotocol/permit-utils/-/permit-utils-0.7.0-RC.0.tgz#a7efce813b68b4d1d2d937ef8a0de21a93901bb5"
integrity sha512-qbJ9RFO65M2UYodKojlxv4jAclUFqLprmwR5sZZwd3eHSUQ4Nc6sJ6yK5uj1KfMOOz0C1dgqnfBYRwHzYAXIGw==
My initial script failed to detect the changes properly. Thank you for the correction! The lockfile has been properly updated alongside the package.json change, so that aspect of the upgrade is handled correctly.
The only remaining consideration would be to verify that any breaking changes in the RC version are compatible with your existing code, but the dependency management side is properly taken care of.
Summary by CodeRabbit