-
Notifications
You must be signed in to change notification settings - Fork 2
feat(new-chains): add q4 chains #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (1)
Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure WalkthroughThe PR upgrades Changes
Sequence DiagramsequenceDiagram
participant ChainContext
participant setGlobalAdapter
participant EthersV5Adapter
participant Provider
ChainContext->>Provider: obtain provider
ChainContext->>EthersV5Adapter: new EthersV5Adapter(provider)
activate EthersV5Adapter
EthersV5Adapter-->>ChainContext: adapter instance
deactivate EthersV5Adapter
ChainContext->>setGlobalAdapter: setGlobalAdapter(adapter)
setGlobalAdapter-->>ChainContext: global adapter configured
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| kind: kindToString(order.kind.toString()), | ||
| sellTokenBalance: balanceToString(order.sellTokenBalance.toString()), | ||
| buyTokenBalance: balanceToString(order.buyTokenBalance.toString()), | ||
| appData: order.appData as string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: do we have any guard for this? I've just remembered the case when appData was incorrect and our explorer page was broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope not. The type is defined in the SDK as Bytes, which is an alias for unknown.
Here I took the shortest path and used a casting.
|
Nice, it works |
Description
Add Linea and Plasma by updating SDK to latest version.
It also required some minor adjustments to work with the new multi-pkg sdk
Changes
How to test
{ "networks": [ { "name": "linea", "rpc": "https://rpc.linea.build", "deploymentBlock": 25028604, "filterPolicy": { "defaultAction": "ACCEPT", "conditionalOrderIds": { "0x5b3cdb6ffa3c95507cbfc459162609007865c2e87340312d3cd469c4ffbfae81": "DROP" }, "transactions": { "0x33ef06af308d1e4f94dd61fa8df43fe52b67e8a485f4e4fff75235080e663bfa": "DROP" }, "handlers": { "0xd3338f21c89745e46af56aeaf553cf96ba9bc66f": "DROP" }, "owners": { "0xd3338f21c89745e46af56aeaf553cf96ba9bc66f": "DROP" } } } ] }Summary by CodeRabbit
New Features
Chores