-
Notifications
You must be signed in to change notification settings - Fork 80
feat: Support need_play_prologue and prologue_content in ChatUpdateEventData #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughTwo new fields, Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
api/src/main/java/com/coze/openapi/client/websocket/event/model/ChatUpdateEventData.java (1)
28-32
: Consider using the primitiveboolean
instead ofBoolean
unlessnull
carries semanticsIf
needPlayPrologue
can only betrue
orfalse
, switching to the primitive avoids boxing overhead and eliminates the potentialNullPointerException
risk when the field is accessed before deserialization populates it.- private Boolean needPlayPrologue; + private boolean needPlayPrologue;Keep it as
Boolean
only if the tri-state (true
/false
/null
) is required to distinguish “unset” from explicit values.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
api/src/main/java/com/coze/openapi/client/websocket/event/model/ChatUpdateEventData.java
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: test (Java 8 on macOS)
- GitHub Check: test (Java 17 on macOS)
- GitHub Check: test (Java 11 on macOS)
- GitHub Check: test (Java 17 on Windows)
- GitHub Check: test (Java 11 on Windows)
- GitHub Check: test (Java 17 on Ubuntu)
- GitHub Check: test (Java 11 on Ubuntu)
Add support to the following params in streaming chat event update data, changes have been verified to be valid:
Reference doc: https://www.coze.cn/open/docs/developer_guides/streaming_chat_event