Skip to content

Conversation

kasarolzzw
Copy link
Collaborator

@kasarolzzw kasarolzzw commented Sep 2, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

lsy357 and others added 30 commits August 15, 2025 13:51
- code sync with 148b388758f4918ac9cbf813311747692f65d15e
- code sync with e72deb1c73a8e4efbdd40bc1d348cbd09ae5b46f
- code sync with 2274c17d200e51d5f38b343827825a7c2fcb1c09
- code sync with 274dfb796e6b33a4206907a79ab71c574aedc141
- feat(evaluation): support expt report exporting
- feat(evaluation): support expt result manual annotation
- feat(evaluation): expt configuration with optional target/evaluators
- feat(evaluation): expt support prompt target param
- code sync with 874d033a0bdeee65f04b4db2c52be235431677fe
- code sync with f4d7bea30a52e58858a8726ddd0e3821d05be175
Change-Id: If2435e708c47443fb752e2985584ba104474ea1a
yyyhhl and others added 10 commits September 3, 2025 15:48
Change-Id: I74e03d863888d1752da5197cf77e0d6ebd8c0ba6
Change-Id: I67107760f9c65d068626c81d2b57ab7f663a6716
Change-Id: I500eb5b3a2c0dbb52e455298b538a8859aecb7b5
Change-Id: I4895a93dbbe1ca2403351aac9da1775ece0a1ec1
(LogID: 202509082215400100911040164450228)

Co-Authored-By: Coda <[email protected]>
Change-Id: I120027a025d2e8f84655fa2e41a8dae0ac56c958
Change-Id: Ic6a504d00e5314694ce1340274d3182109fe2b11
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 85.08634% with 95 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...i/handler/coze/loop/apis/prompt_open_apiservice.go 0.00% 32 Missing ⚠️
...nd/modules/prompt/application/convertor/openapi.go 89.08% 14 Missing and 5 partials ⚠️
backend/modules/prompt/application/openapi.go 95.73% 8 Missing and 8 partials ⚠️
backend/modules/prompt/infra/rpc/convertor/chat.go 38.09% 13 Missing ⚠️
backend/api/router/coze/loop/apis/middleware.go 0.00% 6 Missing ⚠️
backend/pkg/goroutine/goroutine.go 40.00% 5 Missing and 1 partial ⚠️
...ackend/api/router/coze/loop/apis/coze.loop.apis.go 0.00% 2 Missing ⚠️
.../modules/prompt/infra/collector/event_collector.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   57.86%   58.20%   +0.33%     
==========================================
  Files         510      511       +1     
  Lines       52733    53355     +622     
==========================================
+ Hits        30516    31055     +539     
- Misses      19847    19919      +72     
- Partials     2370     2381      +11     
Flag Coverage Δ
unittests 58.20% <85.08%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/llm/domain/entity/common.go 100.00% <ø> (ø)
backend/modules/prompt/application/debug.go 62.25% <100.00%> (ø)
...mpt/domain/component/trace/trace_span_convertor.go 77.16% <ø> (ø)
...kend/modules/prompt/domain/entity/prompt_detail.go 84.44% <ø> (ø)
backend/modules/prompt/infra/conf/prompt.go 29.41% <100.00%> (+29.41%) ⬆️
.../modules/prompt/infra/collector/event_collector.go 75.00% <0.00%> (-25.00%) ⬇️
...ackend/api/router/coze/loop/apis/coze.loop.apis.go 0.00% <0.00%> (ø)
backend/api/router/coze/loop/apis/middleware.go 0.00% <0.00%> (ø)
backend/pkg/goroutine/goroutine.go 40.00% <40.00%> (ø)
backend/modules/prompt/infra/rpc/convertor/chat.go 80.33% <38.09%> (-3.59%) ⬇️
... and 3 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac6ef6...cb70d40. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kasarolzzw and others added 11 commits September 9, 2025 00:29
(LogID: 20250909001221192168001017163981A)

Co-Authored-By: Coda <[email protected]>
Change-Id: I494a2996401be2625a765968712892840edaa08c
(LogID: 202509090114481921680010173601B37)

Co-Authored-By: Coda <[email protected]>
Change-Id: I1210dcf015f41fd6e70ae31cbf706df8158ba013
(LogID: 202509090213171921680010170408728)

Co-Authored-By: Coda <[email protected]>
Change-Id: Ia83d24167162eacdabab2cb9e23b27661fd8c8f3
Change-Id: I2ed9ca868ffc389dff76d147f319f00b91f89b36
Change-Id: I9e1cd869a8f0c108f9711c617c83afe1e075c638
Change-Id: I029c844f024cf7a2cb951cfebdc831f734d45f2a
Change-Id: I5ddcb17c06c6a89533f98bd5a1b42d5a9a11a5ef
Change-Id: I9f65996f36ba63782ddc20d33f96ff5c42157b93
Copy link
Collaborator Author

@kasarolzzw kasarolzzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码审查总结

本次审查发现了5个重要问题,包括1个严重的资源泄漏风险、1个HTTP状态码设置问题,以及3个改进建议。主要关注点:

  1. 🚫必须修复: ExecuteStreaming函数存在严重的资源泄漏风险
  2. 🚨应该修复: HTTP状态码设置时机不当
  3. 💡建议: 代码风格和依赖管理优化

请优先处理标记为"必须修复"的问题,确保系统的稳定性和安全性。

Change-Id: I9c86a702828fbd017922d1328ef3720f8004b29d
Change-Id: I75bd2a6c5f15bb47f67dd38ffabad3f9dcb039e4
@kasarolzzw kasarolzzw merged commit df69c51 into main Sep 9, 2025
10 checks passed
@kasarolzzw kasarolzzw deleted the feat-ptaas branch September 9, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants