-
Notifications
You must be signed in to change notification settings - Fork 678
[feat][prompt] prompt as a service (ptaas) #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- code sync with 148b388758f4918ac9cbf813311747692f65d15e
- code sync with e72deb1c73a8e4efbdd40bc1d348cbd09ae5b46f
- code sync with 2274c17d200e51d5f38b343827825a7c2fcb1c09
- code sync with 274dfb796e6b33a4206907a79ab71c574aedc141 - feat(evaluation): support expt report exporting - feat(evaluation): support expt result manual annotation - feat(evaluation): expt configuration with optional target/evaluators - feat(evaluation): expt support prompt target param
- code sync with 874d033a0bdeee65f04b4db2c52be235431677fe
- code sync with f4d7bea30a52e58858a8726ddd0e3821d05be175
Change-Id: I74e03d863888d1752da5197cf77e0d6ebd8c0ba6
Change-Id: I67107760f9c65d068626c81d2b57ab7f663a6716
Change-Id: I4895a93dbbe1ca2403351aac9da1775ece0a1ec1
(LogID: 202509082215400100911040164450228) Co-Authored-By: Coda <[email protected]>
(LogID: 20250909001221192168001017163981A) Co-Authored-By: Coda <[email protected]>
(LogID: 202509090114481921680010173601B37) Co-Authored-By: Coda <[email protected]>
(LogID: 202509090213171921680010170408728) Co-Authored-By: Coda <[email protected]>
kasarolzzw
commented
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码审查总结
本次审查发现了5个重要问题,包括1个严重的资源泄漏风险、1个HTTP状态码设置问题,以及3个改进建议。主要关注点:
- 🚫必须修复: ExecuteStreaming函数存在严重的资源泄漏风险
- 🚨应该修复: HTTP状态码设置时机不当
- 💡建议: 代码风格和依赖管理优化
请优先处理标记为"必须修复"的问题,确保系统的稳定性和安全性。
wanglizhi
reviewed
Sep 9, 2025
wanglizhi
reviewed
Sep 9, 2025
ming845378603
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: