feat: Use parent origin instead of document.referrer #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
force-pushed
the
feat/parent-location
branch
from
8573a34 to
bcb4fed
Compare
We sent message from iframe to origin infered document.referrer because document.referrer, when in an iframe, is set initially to the iframe URL. But if a redirection happens in the iframe (which happens during an oauth login) document.referrer is updated. So we sent message from iframe to the wrong origin. Here we introduce a way to ask the parent window, if it exists, his origin. We just take the origin from the parent window answer metadata. We do not trust the parent window. By doing this, bridge will be able to work even after a reload or a redirection inside the iframe.
zatteo
force-pushed
the
feat/parent-location
branch
from
bcb4fed to
c761b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sent message from iframe to origin infered document.referrer because document.referrer, when in an iframe, is set initially to the iframe URL. But if a redirection happens in the iframe (which happens during an oauth login) document.referrer is updated. So we sent message from iframe to the wrong origin.
Here we introduce a way to ask the parent window, if it exists, his origin. We just take the origin from the parent window answer metadata. We do not trust the parent window.
By doing this, bridge will be able to work even after a reload or a redirection inside the iframe.