Conversation
shepilov
force-pushed
the
feat/shared-drive-readonly-recipient-create-link
branch
from
441c7a5 to
5fd6dde
Compare
taratatach
reviewed
Mar 18, 2026
shepilov
force-pushed
the
feat/shared-drive-readonly-recipient-create-link
branch
2 times, most recently
from
facbc0d to
50e7b8e
Compare
…by-link permissions # Conflicts: # web/sharings/drives.go
shepilov
force-pushed
the
feat/shared-drive-readonly-recipient-create-link
branch
from
50e7b8e to
a537686
Compare
taratatach
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior was too strict: read-only members could already see existing read-only links, but they were blocked from creating the same kind of link themselves.
The change only allows read-only link creation, while still forbidding read-only members from modifying or revoking share-by-link permissions afterward.