CMake: Do not search parent directories for Git metadata - #1028
Merged
Conversation
Contributor
Author
|
Looks like the tests are not that robust... |
Member
|
@mtaillefumier can you review it? thanks... |
mtaillefumier
approved these changes
Jul 22, 2026
mtaillefumier
left a comment
mtaillefumier
left a comment
Contributor
There was a problem hiding this comment.
These modifications look alright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DBCSR is embedded in another source tree without its own
.gitmetadata, the current implementation searches parent directories and may use the enclosing project's Git tags and revision information as DBCSR's version.Restrict Git metadata discovery to DBCSR's current source directory. If that directory is not a Git working tree or submodule, fall back to the version information provided by the DBCSR source archive.