-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Minimum Swift Version to 5.9 #218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
978c89d
to
71f86d1
Compare
Closing, since this'll drop SPM support for 5.7 and 5.8. |
b3beec9
to
d207622
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 85.83% 85.88% +0.05%
==========================================
Files 13 13
Lines 1842 1842
==========================================
+ Hits 1581 1582 +1
+ Misses 261 260 -1 ☔ View full report in Codecov by Sentry. |
c51597f
to
8abc72c
Compare
danieleformichelli
approved these changes
Jan 15, 2024
8abc72c
to
b613379
Compare
b613379
to
6d200f8
Compare
6d200f8
to
a6725cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping to Swift 5.9 introduces some particularly helpful new features, namely the
package
access modifier (SE-386). Bumping to Swift 5.9 is a breaking change for consumers ofXcbeautifyLib
, such as Tuist, since their packages will also require Swift 5.9 too. It is not a breaking change if a consumer simply uses thexcbeautify
CLI. Thepackage
access modifier will be particularly helpful to introduce new logic intoXcbeautifyLib
that the executable,xcbeautify
, needs, without unnecessarily making the additions public to third-party consumers.