Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Minimum Swift Version to 5.9 #218

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Bump Minimum Swift Version to 5.9 #218

merged 2 commits into from
Feb 6, 2024

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Jan 1, 2024

Bumping to Swift 5.9 introduces some particularly helpful new features, namely the package access modifier (SE-386). Bumping to Swift 5.9 is a breaking change for consumers of XcbeautifyLib, such as Tuist, since their packages will also require Swift 5.9 too. It is not a breaking change if a consumer simply uses the xcbeautify CLI. The package access modifier will be particularly helpful to introduce new logic into XcbeautifyLib that the executable, xcbeautify, needs, without unnecessarily making the additions public to third-party consumers.

@cpisciotta cpisciotta linked an issue Jan 1, 2024 that may be closed by this pull request
@cpisciotta cpisciotta force-pushed the charles/Swift-5.9 branch 5 times, most recently from 978c89d to 71f86d1 Compare January 7, 2024 00:20
@cpisciotta
Copy link
Owner Author

Closing, since this'll drop SPM support for 5.7 and 5.8.

@cpisciotta cpisciotta closed this Jan 7, 2024
@cpisciotta cpisciotta deleted the charles/Swift-5.9 branch January 7, 2024 00:22
@cpisciotta cpisciotta restored the charles/Swift-5.9 branch January 14, 2024 17:17
@cpisciotta cpisciotta reopened this Jan 14, 2024
@cpisciotta cpisciotta force-pushed the charles/Swift-5.9 branch 3 times, most recently from b3beec9 to d207622 Compare January 14, 2024 17:22
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (083aedf) 85.83% compared to head (a6725cd) 85.88%.

Files Patch % Lines
...ces/XcbeautifyLib/Renderers/TerminalRenderer.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   85.83%   85.88%   +0.05%     
==========================================
  Files          13       13              
  Lines        1842     1842              
==========================================
+ Hits         1581     1582       +1     
+ Misses        261      260       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta force-pushed the charles/Swift-5.9 branch 6 times, most recently from c51597f to 8abc72c Compare January 14, 2024 22:44
@cpisciotta cpisciotta marked this pull request as ready for review January 30, 2024 03:13
@cpisciotta cpisciotta marked this pull request as draft January 30, 2024 03:17
@cpisciotta cpisciotta marked this pull request as ready for review February 6, 2024 19:31
@cpisciotta cpisciotta changed the title Update to Swift 5.9 Bump Minimum Swift Version to 5.9 Feb 6, 2024
@cpisciotta cpisciotta merged commit 7258a03 into main Feb 6, 2024
6 of 7 checks passed
@cpisciotta cpisciotta deleted the charles/Swift-5.9 branch February 6, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Swift 5.9
2 participants