Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Formatting to CaptureGroup Definitions #232

Closed
wants to merge 4 commits into from
Closed

Conversation

cpisciotta
Copy link
Owner

In an effort to simplify the codebase, introduce a formatted method as a CaptureGroup protocol requirement. This'll house the formatted output, eliminating the need for separate OutputRendering definitions and switch logic.

@cpisciotta cpisciotta force-pushed the beautify branch 2 times, most recently from d62fb08 to 60deecc Compare January 7, 2024 16:33
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (092bb2d) 85.76% compared to head (31d9715) 86.80%.

Files Patch % Lines
Sources/XcbeautifyLib/CaptureGroups.swift 88.56% 39 Missing ⚠️
Sources/XcbeautifyLib/TestSummary.swift 0.00% 12 Missing ⚠️
Sources/XcbeautifyLib/Parser.swift 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   85.76%   86.80%   +1.04%     
==========================================
  Files          14       11       -3     
  Lines        1545     1258     -287     
==========================================
- Hits         1325     1092     -233     
+ Misses        220      166      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta
Copy link
Owner Author

Closing this, since it tightly couples formatting to the concrete types.

@cpisciotta cpisciotta closed this Feb 22, 2024
@cpisciotta cpisciotta deleted the beautify branch February 22, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant