Migrate Formatting to CaptureGroup Definitions #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpisciotta
force-pushed
the
beautify
branch
2 times, most recently
from
d62fb08 to
60deecc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 85.76% 86.80% +1.04%
==========================================
Files 14 11 -3
Lines 1545 1258 -287
==========================================
- Hits 1325 1092 -233
+ Misses 220 166 -54 ☔ View full report in Codecov by Sentry. |
cpisciotta
force-pushed
the
beautify
branch
5 times, most recently
from
6e63801 to
b775d2c
Compare
|
Closing this, since it tightly couples formatting to the concrete types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to simplify the codebase, introduce a
formattedmethod as aCaptureGroupprotocol requirement. This'll house the formatted output, eliminating the need for separateOutputRenderingdefinitions and switch logic.