Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete TestSummary #237

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Delete TestSummary #237

merged 4 commits into from
Jul 30, 2024

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Jan 14, 2024

Changes

Delete custom TestSummary logic. Instead, parse and use the output given by xcodebuild. This'll significantly simplify xcbeautify's codebase, give users more information, and more closely match xcodebuild's raw output.

Testing

Test 1

swift build && swift test | ./.build/debug/xcbeautify --disable-colored-output > filename.txt

Old New
Run 1 - Time 19.24 seconds 12.67 seconds
Run 1 - Log old1.txt new1.txt
Run 2 - Time 12.48 seconds 12.85 seconds
Run 2 - Log old2.txt new2.txt
Run 3 - Time 12.86 12.93 seconds
Run 3 - Log old3.txt new3.txt

Test 2

make measure

Old New
Run 1 4.74 seconds 4.91 seconds
Run 2 4.76 seconds 4.71 seconds
Run 3 4.78 seconds 4.73 seconds

Example Output

Old

TerminalRendererTests
    ✔ testAggregateTarget (0.000 seconds)
    ...
    ✔ testXcodeprojError (0.000 seconds)
    ✔ testXcodeprojWarning (0.000 seconds)
Tests Passed: 0 failed, 0 skipped, 306 total (12.477 seconds)

New

TerminalRendererTests
    ✔ testAggregateTarget (0.000 seconds)
    ...
    ✔ testXcodeprojError (0.000 seconds)
    ✔ testXcodeprojWarning (0.000 seconds)
Executed 99 tests, with 0 failures (0 unexpected) in 0.014 (0.015) seconds
Test Suite 'xcbeautifyPackageTests.xctest' passed at 2024-07-29 20:38:00.325.
Executed 306 tests, with 0 failures (0 unexpected) in 12.355 (12.360) seconds
Test Suite 'All tests' passed at 2024-07-29 20:38:00.325.
Executed 306 tests, with 0 failures (0 unexpected) in 12.355 (12.361) seconds

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (d7c9ce7) to head (b193882).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   85.76%   87.79%   +2.02%     
==========================================
  Files          15       14       -1     
  Lines        1665     1614      -51     
==========================================
- Hits         1428     1417      -11     
+ Misses        237      197      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 3 times, most recently from a2a5342 to cac7965 Compare February 23, 2024 01:07
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 3 times, most recently from 5e1180a to c342784 Compare March 1, 2024 04:48
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 3 times, most recently from 307c9e7 to 796761c Compare March 12, 2024 02:43
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 2 times, most recently from 81d55fa to 492afd1 Compare March 12, 2024 03:19
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 2 times, most recently from cda9383 to 6822557 Compare April 27, 2024 02:28
@cpisciotta cpisciotta changed the title [WIP] Delete TestSummary Delete TestSummary Apr 27, 2024
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 2 times, most recently from b12bccb to 1418143 Compare April 27, 2024 04:38
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch from 1418143 to 02b831b Compare May 16, 2024 13:54
@cpisciotta cpisciotta force-pushed the DeleteTestSummary branch 2 times, most recently from 1418143 to 2c6f909 Compare July 23, 2024 01:10
@cpisciotta cpisciotta marked this pull request as ready for review July 30, 2024 01:02
@cpisciotta cpisciotta merged commit 9c598e2 into main Jul 30, 2024
7 checks passed
@cpisciotta cpisciotta deleted the DeleteTestSummary branch July 30, 2024 01:04
@amidaleet
Copy link

That's regression, changes like that should be published as a major SemVer update.

I relied on this summary line as source for auto test scheme size dynamic metrics.
Also line is still remains in a fresh README.md screenshot. Creates false expectations 🙂
example

Now I have to grep Test_Scheme_run.log and use counter.
If anyone else has similar task, may adopt my ruby script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants