-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Parser and Introduce Formatter #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9585694
to
0121351
Compare
aa07bc9
to
9f43e96
Compare
0121351
to
29f3a3b
Compare
9f43e96
to
3f736d2
Compare
29f3a3b
to
a2a5342
Compare
3f736d2
to
5fb64d4
Compare
a2a5342
to
cac7965
Compare
b37d720
to
050c0c7
Compare
cac7965
to
7cb16db
Compare
ec7b9b6
to
1f8cf1b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 87.79% 86.81% -0.99%
==========================================
Files 14 14
Lines 1614 1600 -14
==========================================
- Hits 1417 1389 -28
- Misses 197 211 +14 ☔ View full report in Codecov by Sentry. |
5e1180a
to
c342784
Compare
492afd1
to
84c210e
Compare
1f8cf1b
to
ff20a03
Compare
84c210e
to
cd91c1e
Compare
cda9383
to
6822557
Compare
d4434f8
to
837b9b7
Compare
3a7cad1
to
d1bad2e
Compare
d1bad2e
to
bb496b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Major
Simplify
Parser
to exclusively implement its intended functionality: parsing. Separate formatting-related logic into a new type,Formatter
.Move the
beautify
method fromOutputRendering
toFormatter
, delete the unnecessary extension onString
, and updateJunitReporter
as necessary. UpdateXCBeautifier
and the executable to wrapParser
,Formatter
, and output-related logic.Minor
package
-accessible, as necessary.Testing
Performance