Ranges ranges ranges by jwakely · Pull Request #533 · cplusplus/LWG

jwakely · 2025-12-11T16:22:57Z

A series of changes to make more use of modern C++20 features.

Several functions can be made more generic by using std::span instead of passing references to std::vector.

Some loops are changed to loop over a span and remove the prefix that has been processed.

Using projections with ranges algos simplifies several places.

jwakely · 2025-12-12T13:21:09Z

No changes to the generated HTML except as noted in one commit:

Add report_generator::make_sort_by_status_impl helper

Common impl for make_sort_by_status and make_sort_by_status_mod_date.

This changes the generated HTML slightly, because it means that the
lwg-status.html, unresolved-status.html, and voting-status.html pages
now have OpenGraph metadata:

--- mailing.orig/lwg-status.html        2025-12-10 23:22:08.142390521 +0000
+++ mailing.good/lwg-status.html        2025-12-11 11:57:02.753796799 +0000
@@ -3,6 +3,12 @@
 <head>
 <meta charset="utf-8">
 <title>LWG Index by Status and Section</title>
+<meta property="og:title" content="LWG Index by Status and Section">
+<meta property="og:description" content="C++ standard library issues list">
+<meta property="og:url" content="https://cplusplus.github.io/LWG/lwg-status.html">
+<meta property="og:type" content="website">
+<meta property="og:image" content="http://cplusplus.github.io/LWG/images/cpp_logo.png">
+<meta property="og:image:alt" content="C++ logo">
 <style>
   p {text-align:justify}
   li {text-align:justify}

This seems like a good change. It makes those pages consistent with the
equivalent *-status-date.html pages.

The *-status-date.html pages get an extra blank line in the HTML as
well, because all those *-status*.html pages are generated by the same
function now.

tomaszkam · 2025-12-12T15:01:20Z

   out << "<p>" << build_timestamp << "</p>";

-   for (auto i = issues.cbegin(), e = issues.cend(); i != e;) {
+   for (auto i = issues.begin(), e = issues.end(); i != e;) {


Maybe use chunk_by(issues, [](const issue& lhs, const& issue rhs) { return lhs.stat != rhs.stat; }); if we can depend on that.

The code is compiled with -std=c++20 currently. We could change that, if everybody working with the issues has a compiler that can handle C++23.

tomaszkam · 2025-12-12T15:46:04Z

-      out << "<h2 id=\"" << idattr << "\">" << current_status << " (" << (j-i) << " issues)</h2>\n";
-      print_table(out, {i, j}, section_db);
-      i = j;
+   while (!issues.empty())


This also seem like chunk_by.

tomaszkam

LGTM. I have noted a few places where you could improve by using chunk_by.

Also replace some loops with range-based for.

Common impl for make_sort_by_status and make_sort_by_status_mod_date. This changes the generated HTML slightly, because it means that the lwg-status.html, unresolved-status.html, and voting-status.html pages now have OpenGraph metadata: --- mailing.orig/lwg-status.html 2025-12-10 23:22:08.142390521 +0000 +++ mailing.good/lwg-status.html 2025-12-11 11:57:02.753796799 +0000 @@ -3,6 +3,12 @@ <head> <meta charset="utf-8"> <title>LWG Index by Status and Section</title> +<meta property="og:title" content="LWG Index by Status and Section"> +<meta property="og:description" content="C++ standard library issues list"> +<meta property="og:url" content="https://cplusplus.github.io/LWG/lwg-status.html"> +<meta property="og:type" content="website"> +<meta property="og:image" content="http://cplusplus.github.io/LWG/images/cpp_logo.png"> +<meta property="og:image:alt" content="C++ logo"> <style> p {text-align:justify} li {text-align:justify} This seems like a good change. It makes those pages consistent with the equivalent *-status-date.html pages. The *-status-date.html pages get an extra blank line in the HTML as well, because all those *-status*.html pages are generated by the same function now.

…jections Ranges algos can just use a pointer-to-member projection instead.

…range algos

Also remove outdated comment and alternative code that is no simpler.

As suggested by Tomasz in cplusplus#533 Use a helper function for C++20.

As suggested by Tomasz in #533 Use a helper function for C++20.

jwakely added 2 commits December 12, 2025 13:15

Use std::string::ends_with for checking file extension

84f5918

Use ranges::sort and ranges::copy for printing sorted vector

ff6810c

jwakely force-pushed the ranges-ranges-ranges branch from a8ccbd2 to 569de89 Compare December 12, 2025 13:20

jwakely force-pushed the ranges-ranges-ranges branch from 569de89 to 3653804 Compare December 12, 2025 13:29

tomaszkam reviewed Dec 12, 2025

View reviewed changes

Comment thread src/list_issues.cpp Outdated

tomaszkam reviewed Dec 12, 2025

View reviewed changes

Comment thread src/toc_diff.cpp Outdated

tomaszkam reviewed Dec 12, 2025

View reviewed changes

tomaszkam approved these changes Dec 12, 2025

View reviewed changes

jwakely added 15 commits December 12, 2025 17:39

Use std::span (almost) everywhere

f772b79

Also replace some loops with range-based for.

Use std::string_view in toc_diff.cpp helper functions

701c779

Use ranges::count_if and structured bindings in toc_diff.cpp

9732224

Remove redundant spaces between closing angle brackets

5ace617

Use std::span and ranges algos in format_issue_as_html

6742cd2

Use ranges algos for sorted tables in report_generator

a2bf61d

Replace remaining uses of lwg::order_by_issue_number functor with pro…

8a30bbc

…jections Ranges algos can just use a pointer-to-member projection instead.

Micro-optimization for lwg::is_active_not_ready

58673d1

Use string_view for some string constants

b212580

Simplify lwg::get_status_priority

286e71f

Refactor report_generator::make_sort_by_section to use std::span and …

cae1663

…range algos

Use structured bindings in lists.cpp

9a7db8b

Micro-optimization in prepare_issues_for_diff_report

8adcf62

Also remove outdated comment and alternative code that is no simpler.

Use ranges::to when available and ranges::transform otherwise

6ccf1d9

jwakely force-pushed the ranges-ranges-ranges branch from 3653804 to 6ccf1d9 Compare December 12, 2025 18:45

jwakely merged commit 7d7b466 into cplusplus:master Dec 12, 2025
2 checks passed

jwakely deleted the ranges-ranges-ranges branch December 12, 2025 18:48

jwakely added a commit to jwakely/LWG that referenced this pull request Dec 12, 2025

Change loops over equivalent issues to use C++23 views::chunk_by

dbab6b1

As suggested by Tomasz in cplusplus#533 Use a helper function for C++20.

jwakely mentioned this pull request Dec 12, 2025

Change loops over equivalent issues to use C++23 views::chunk_by #535

Merged

jwakely added a commit to jwakely/LWG that referenced this pull request Dec 12, 2025

Change loops over equivalent issues to use C++23 views::chunk_by

b573f35

As suggested by Tomasz in cplusplus#533 Use a helper function for C++20.

jwakely added a commit to jwakely/LWG that referenced this pull request Dec 12, 2025

Change loops over equivalent issues to use C++23 views::chunk_by

81282c2

As suggested by Tomasz in cplusplus#533 Use a helper function for C++20.

jwakely added a commit to jwakely/LWG that referenced this pull request Dec 12, 2025

Change loops over equivalent issues to use C++23 views::chunk_by

d475a96

As suggested by Tomasz in cplusplus#533 Use a helper function for C++20.

jwakely added a commit to jwakely/LWG that referenced this pull request Dec 12, 2025

Change loops over equivalent issues to use C++23 views::chunk_by

2b989ee

As suggested by Tomasz in cplusplus#533 Use a helper function for C++20.

jwakely added a commit that referenced this pull request Dec 13, 2025

Change loops over equivalent issues to use C++23 views::chunk_by

15cc908

As suggested by Tomasz in #533 Use a helper function for C++20.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ranges ranges ranges#533

Ranges ranges ranges#533
jwakely merged 17 commits intocplusplus:masterfrom
jwakely:ranges-ranges-ranges

jwakely commented Dec 11, 2025

Uh oh!

jwakely commented Dec 12, 2025

Uh oh!

Uh oh!

tomaszkam Dec 12, 2025

Uh oh!

jwakely Dec 12, 2025

Uh oh!

Uh oh!

tomaszkam Dec 12, 2025

Uh oh!

tomaszkam left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jwakely commented Dec 11, 2025

Uh oh!

jwakely commented Dec 12, 2025

Uh oh!

Uh oh!

tomaszkam Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

jwakely Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tomaszkam Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

tomaszkam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants