Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BundleToResources adjustment and optimization #543

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

echicoine-icf
Copy link
Contributor

@echicoine-icf echicoine-icf commented Jan 14, 2025

Changes:

  • Retain folder structure to easily trace source of extracted resources
  • Added new argument handling to delete bundles after operation completes: -db=true
  • Added new BundleToResources test to account for new delete bundle argument
  • Optimized code to handle large file loads
  • Adjusted ThreadUtils after discovering macOS/linux does not handle cached executor as Windows does. Executor set to fixed thread pool (cpu core count * 2)

https://icf.atlassian.net/browse/CQF-2407

  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

echicoine-icf and others added 11 commits January 5, 2025 15:29
…p processing of files (not json or xml, or matches output path)
…after the bundle, but folder structure of where files originate from is retained.
…o run use -db=true, updated test with new delete feature.
…tem. Also correcting an issue where a reused instance of BundleToResources() was erroneously passing in -db=true to a test that shouldn't have it.
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 59.60265% with 61 lines in your changes missing coverage. Please review.

Project coverage is 21.74%. Comparing base (1639731) to head (4e8e7ee).

Files with missing lines Patch % Lines
...encds/cqf/tooling/operation/BundleToResources.java 58.21% 40 Missing and 21 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #543      +/-   ##
============================================
+ Coverage     21.56%   21.74%   +0.18%     
- Complexity     1673     1684      +11     
============================================
  Files           299      299              
  Lines         25781    25881     +100     
  Branches       4072     4091      +19     
============================================
+ Hits           5560     5629      +69     
- Misses        19300    19318      +18     
- Partials        921      934      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants