added the path code variable to the env var name PATH_LOCATION using enviroment variable#1
Open
jairoandrescastaneda wants to merge 2 commits intocr0wg4n:masterfrom
Open
Conversation
added 2 commits
October 4, 2020 14:13
… to the final in the path location if this not ended with /
Owner
|
Hi @jairoufps you can use os.path.join (function built-in) to improve some parts of this script, and if you introduce an auxiliary module, I would prefer that name should be 'utils', thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the idea to this change is to avoid entering the code to change only one variable