Added FromLLArray service #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrton04
requested changes
Jan 26, 2025
| return true; | ||
| } | ||
|
|
||
| geometry_msgs::msg::Point NavSatTransform::fromLL( |
There was a problem hiding this comment.
This throws an exception now. I just want to make sure that we're catching it everywhere it's called. I haven't looked through the code to remind myself. :)
There was a problem hiding this comment.
its called from:
- NavSatTransform::fromLLCallback
- NavSatTransform::fromLLArrayCallback
each of which does have it wrapped in a try catch
No problem. Each of your comments should be handled now |
ayrton04
approved these changes
Feb 4, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of #676 since that one seems to be abandoned.
This adds a service that allows conversions of lists of lat/lon pairs instead of having to request them one at a time.