fix(client): replace inline skeleton divs with canonical Skeleton component - #952
Open
Nuel-ship-it wants to merge 2 commits into
Open
fix(client): replace inline skeleton divs with canonical Skeleton component#952Nuel-ship-it wants to merge 2 commits into
Nuel-ship-it wants to merge 2 commits into
Conversation
…nical ui/Skeleton - Update ui/Skeleton to use bg-gray-200 dark:bg-white/5 rounded-2xl to match the semantics previously defined inline in RafflePage - Remove local Skeleton definition from RafflePage.tsx - Import Skeleton from components/ui/Skeleton instead No other pages or components had inline Skeleton definitions.
…ponent (crackedstudio#767) - RaffleDetails.tsx: replace animate-pulse loading block with <Skeleton> - MyRaffles.tsx: replace animate-pulse history/profile loading with <Skeleton> - CreatorProfile.tsx: replace animate-pulse raffle grid loading with <Skeleton> All three files now import from components/ui/Skeleton, ensuring consistent animate-pulse bg-gray-200 dark:bg-white/5 rounded-2xl styling everywhere.
|
@Nuel-ship-it is attempting to deploy a commit to the otaiki1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
FIX CONFLICTS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #767
Changes
Replaced all raw
animate-pulseloading skeleton divs in pages with the canonical<Skeleton>component fromcomponents/ui/Skeleton.RaffleDetails.tsxanimate-pulse/bg-gray-700divs in loading block with<Skeleton>MyRaffles.tsx<Skeleton>CreatorProfile.tsx<Skeleton>Notes
RafflePage.tsxalready importedui/Skeleton— no change neededanimate-pulsein pages are intentional (live status dot, winner celebration border,StatCardSkeletonin Transparency.tsx)Acceptance criteria
client/src/pages/defines a localSkeletoncomponentui/Skeletonis used everywhere loading skeletons appear