Bugfix/edit config template and classes #494
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where some classes were not used when adding a code editor field to the CKEditor Config edit form.
For example, the
monaco-editor-background-framewas missing from the “Custom Styles” field. Thehas-errorsclass was missing from the “Custom Options” field if there was an error with the JSON configuration, and it was also missing its css styles.Note that it’s a bit harder to test this at the moment (you can see it in the code, but some parts have no visual cues), as there’s an issue with the Monaco editor.
Related issues
n/a