Skip to content

Add key to registerHtml #17365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Draft

Conversation

brianjhanson
Copy link
Contributor

@brianjhanson brianjhanson commented May 29, 2025

Ensures the fetch call will only happen once per page load

Ensures the `fetch` call will only happen once per page
@brianjhanson brianjhanson requested a review from timkelty May 29, 2025 20:33
@AugustMiller
Copy link
Contributor

Are we seeing this happening in the wild? 😮 It's typically safe to use {% js %}, {% css %}, {% html %}, and the underlying craft\web\View "register" methods with the same strings multiple times… in each case, the fragments are held under md5 hashes of their content, which I would expect to be identical!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants