Hover/NBT fixes per OstlerDev #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crashdemons
requested changes
Oct 29, 2025
Owner
crashdemons
left a comment
crashdemons
left a comment
There was a problem hiding this comment.
Needs further investigation into BungeeChat serialization/NBT or GSON errors.
| try { | ||
| // Note: `serializeItemAsJson` is a Paper API method | ||
| Map<String, Object> serializedItem = bukkitItem.serialize(); | ||
| String json = GSON.toJson(serializedItem); |
Owner
There was a problem hiding this comment.
This is skipped in my test environment due to a ReflectionOperationException from GSON.
Not sure if this my issue or GSON's.
| try { | ||
| nbt = bukkitItem.getItemMeta().getAsString(); | ||
| final net.md_5.bungee.api.chat.ItemTag tag = (nbt != null && !nbt.isEmpty()) ? net.md_5.bungee.api.chat.ItemTag.ofNbt(nbt) : null; | ||
| return new HoverEvent(HoverEvent.Action.SHOW_ITEM, new net.md_5.bungee.api.chat.hover.content.Item(id, count, tag)); |
Owner
There was a problem hiding this comment.
This code runs and works for me, but doesn't display the metadata in the chat.
(just getting this into github so I don't forget)
This is also basically the same as what I'm doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.