Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Dec 26, 2025

Just maintenance. Dependents are not ready for Python 3.14, yet.

@coderabbitai
Copy link

coderabbitai bot commented Dec 26, 2025

Walkthrough

This pull request updates Python version references across three GitHub Actions workflow files, replacing Python 3.13 with Python 3.14 in CI test matrices and dependency installation steps. No functional or behavioral changes to workflow logic.

Changes

Cohort / File(s) Summary
Python 3.14 version updates in CI workflows
.github/workflows/kinesis.yml, .github/workflows/postgresql.yml, .github/workflows/release-app.yml
Updated Python version from 3.13 to 3.14 in test matrices (kinesis, postgresql) and installation steps (release-app)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • surister
  • hammerhead

Poem

🐰 Hop hop, a version so new,
Python 3.14 runs workflows through,
From 3.13 we did depart,
CI pipelines dance, a modern art!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating CI workflows to use Python 3.14 instead of 3.13 across multiple workflows.
Description check ✅ Passed The description is related to the changeset, indicating this is maintenance work and explaining that dependents are not yet ready for Python 3.14, providing context for the CI updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch python314-next

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75c1668 and 03ead51.

📒 Files selected for processing (3)
  • .github/workflows/kinesis.yml
  • .github/workflows/postgresql.yml
  • .github/workflows/release-app.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: amotl
Repo: crate/cratedb-toolkit PR: 563
File: .github/workflows/dynamodb.yml:40-43
Timestamp: 2025-10-25T18:32:49.525Z
Learning: In the cratedb-toolkit repository, Python 3.14 was selectively added to some GitHub Actions workflows (cratedb-cloud.yml, dynamodb.yml, influxdb.yml, main.yml, and release workflows) while other service workflows (kinesis.yml, mongodb.yml, postgresql.yml, pymongo.yml) were intentionally left at previous Python versions due to CI failures when attempting to update them to Python 3.14.
📚 Learning: 2025-10-25T18:32:49.525Z
Learnt from: amotl
Repo: crate/cratedb-toolkit PR: 563
File: .github/workflows/dynamodb.yml:40-43
Timestamp: 2025-10-25T18:32:49.525Z
Learning: In the cratedb-toolkit repository, Python 3.14 was selectively added to some GitHub Actions workflows (cratedb-cloud.yml, dynamodb.yml, influxdb.yml, main.yml, and release workflows) while other service workflows (kinesis.yml, mongodb.yml, postgresql.yml, pymongo.yml) were intentionally left at previous Python versions due to CI failures when attempting to update them to Python 3.14.

Applied to files:

  • .github/workflows/postgresql.yml
  • .github/workflows/kinesis.yml
  • .github/workflows/release-app.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-and-publish
  • GitHub Check: Python 3.9 on OS ubuntu-latest
  • GitHub Check: Python 3.13 on OS ubuntu-latest
  • GitHub Check: Kinesis: Python 3.11 on OS ubuntu-latest
  • GitHub Check: Kinesis: Python 3.14 on OS ubuntu-latest
  • GitHub Check: CFR for OS macos-15-intel
  • GitHub Check: CFR for OS windows-latest
  • GitHub Check: CFR for OS macos-latest
  • GitHub Check: build-and-test
  • GitHub Check: CFR for OS ubuntu-latest
  • GitHub Check: Python 3.13 on OS ubuntu-latest
🔇 Additional comments (3)
.github/workflows/kinesis.yml (1)

42-42: Verify that previous CI failures with Python 3.14 are resolved.

Based on learnings from PR 563, this workflow was previously intentionally excluded from Python 3.14 updates due to CI failures. Since no functional changes are included in this PR to address compatibility issues, please confirm that the previous CI failures have been resolved (either by upstream dependency fixes or Python 3.14 improvements).

Consider monitoring the CI results for this workflow to ensure tests pass with Python 3.14.

.github/workflows/postgresql.yml (1)

48-48: Verify that previous CI failures with Python 3.14 are resolved.

Based on learnings from PR 563, this workflow was previously intentionally excluded from Python 3.14 updates due to CI failures. Please confirm that the previous CI failures have been resolved before merging.

Note: The workflow already uses --prerelease=allow (line 103), which may help with Python 3.14 compatibility if dependencies need pre-release versions.

.github/workflows/release-app.yml (1)

48-48: No compatibility concerns with Python 3.14 and PyInstaller. Current PyInstaller releases officially support Python 3.14, and the project's constraint pyinstaller<7 includes versions with this support.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants