Skip to content

Tests: Fix test_record_missing_required_property after SDK update#109

Open
amotl wants to merge 1 commit into
crate:mainfrom
singer-contrib:fix-ci-202606
Open

Tests: Fix test_record_missing_required_property after SDK update#109
amotl wants to merge 1 commit into
crate:mainfrom
singer-contrib:fix-ci-202606

Conversation

@amotl

@amotl amotl commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Problem

Solution

Adjust the test case test_record_missing_required_property as suggested.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a66a6c53-4cfc-45ff-b82f-706b871f0b91

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

assert "Record Message Validation Error: 'id' is a required property" in str(e.value)
else:
assert "Record Message Validation Error: 1 schema validation error(s)" in str(e.value)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon: How could I update the test case to validate the 'id' is a required property message fragment properly on Python 3.11+? I haven't been able to find a way so far.

@amotl amotl force-pushed the fix-ci-202606 branch 3 times, most recently from 2aad473 to 6eae4aa Compare June 15, 2026 12:34
@amotl amotl changed the title Tests: Fix test_record_missing_required_property for Python 3.11+ Tests: Fix test_record_missing_required_property after SDK update Jun 15, 2026
@amotl

amotl commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@kneth, @bgunebakan, @florinutz: Please review and merge at your disposal.

NB: The conversation with @edgarrmondragon is just optional, only reflecting my observations, and should not block the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Tests went south on June, 4

1 participant