Tests: Fix test_record_missing_required_property after SDK update#109
Tests: Fix test_record_missing_required_property after SDK update#109amotl wants to merge 1 commit into
test_record_missing_required_property after SDK update#109Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| assert "Record Message Validation Error: 'id' is a required property" in str(e.value) | ||
| else: | ||
| assert "Record Message Validation Error: 1 schema validation error(s)" in str(e.value) | ||
|
|
There was a problem hiding this comment.
@edgarrmondragon: How could I update the test case to validate the 'id' is a required property message fragment properly on Python 3.11+? I haven't been able to find a way so far.
2aad473 to
6eae4aa
Compare
test_record_missing_required_property for Python 3.11+test_record_missing_required_property after SDK update
|
@kneth, @bgunebakan, @florinutz: Please review and merge at your disposal. NB: The conversation with @edgarrmondragon is just optional, only reflecting my observations, and should not block the merge. |
Problem
Solution
Adjust the test case
test_record_missing_required_propertyas suggested.