feat: update test workflows to skip API tests and document controller… #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables API/integration tests that were incorrectly categorized as unit tests in CI workflows and documents the current test status for the controllers directory.
- Excludes controllers directory from test execution in both GitHub workflow files
- Creates comprehensive documentation explaining why tests are disabled and future plans
- Adds explanatory comments in workflow configuration to clarify the temporary nature of this change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/controllers/TEST_STATUS.md | New documentation file explaining disabled test status and remediation plan |
| core/.github/workflows/test.yml | Removes controllers from test module list with explanatory comments |
| .github/workflows/docker-crawlab.yml | Adds logic to skip controllers directory during test discovery and execution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/controllers/TEST_STATUS.md
Outdated
| ``` | ||
|
|
||
| --- | ||
| *Disabled: October 9, 2025* |
There was a problem hiding this comment.
The date 'October 9, 2025' appears to be a future date. This should likely be 'October 9, 2024' or the actual current date when this change was made.
Suggested change
| *Disabled: October 9, 2025* | |
| *Disabled: October 9, 2024* |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test status