Migration to Spring Boot 4.0#38
Merged
Merged
Conversation
- Bump Spring Boot from 3.5.0 to 4.0.0 and Spring Framework to 7.0. - Update Spock to 2.4-groovy-5.0 for Groovy 5 compatibility. - Replace Resilience4j retry/circuitbreaker with spring-boot4 starter. - Add OpenTelemetryConfig for OTel beans removed in Spring Boot 4. - Include ADR-032 and the comprehensive migration plan. - Add SpotBugs exclusion for Spock-generated feature methods.
- Update all Jackson core and databind imports to tools.jackson.*. - Preserve com.fasterxml.jackson.annotation imports for compatibility. - Replace ObjectMapper with JsonMapper.builder() in FileOverflowBuffer. - Update AlphaVantageClient to use JsonNode.properties() instead of fields(). - Adjust Spock specs to reflect Jackson 3 type and serialization changes.
- Replace Resilience4j @Retry with Spring native @retryable across clients. - Adopt programmatic RetryTemplate for FinnhubEquityClient and YahooFinanceClient. - Adjust retry counts (maxRetries) to match Spring's semantic (retries after initial). - Enable native resilience via @EnableResilientMethods in TickonomicsApplication. - Update tests to verify native @retryable and RetryTemplate behavior.
- Add braces to single-line if/else blocks for improved readability. - Remove unused imports and optimize remaining ones across computation and ingestion. - Update JUnit and Mockito static imports to be more specific. - Perform minor structural cleanup in KpiProcessor and RegimeDetector.
Benchmark Regression ReportEngine: same-runner A/B (base
Runner: base = AMD EPYC 9V74 80-Core Processor; head = AMD EPYC 9V74 80-Core Processor; same runner = True. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR executes the migration of the Tickonomics core from Spring Boot 3.5.0 to Spring Boot 4.0.0 (Spring Framework 7.0, Spring Security 7, Jakarta EE 11).
This is a significant framework-level upgrade that introduces native resilience, moves to Jackson 3 as the default JSON library, and updates the test suite for Groovy 5 compatibility.
The migration follows the strategy outlined in ADR-032 and the comprehensive Spring Boot 4 Migration Plan included in this PR.
Key Changes
Pre-Merge Verification
Technical Notes