Skip to content

chore(test): update e2e tests - #1274

Merged
odockal merged 1 commit into
crc-org:mainfrom
cbr7:fix_outdated_e2e_tests
Oct 23, 2026
Merged

odockal merged 1 commit into
crc-org:mainfrom
cbr7:fix_outdated_e2e_tests

Conversation

@cbr7

@cbr7 cbr7 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Updated checks for OpenShift Local and its authentication dependency to recognize the current “Installed” and “Disabled” status labels.
    • Status checks now allow additional descriptive text on extension listings and details pages, including before and after disabling or re-enabling the extension.

Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e362b407-d530-4dfe-b8a2-364e1d697242
📥 Commits

Reviewing files that changed from the base of the PR and between 7c50867 and 841639a.

📒 Files selected for processing: 1
  • tests/src/openshift-local-extension.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The OpenShift Local extension tests now expect the statuses Installed and Disabled. Status checks use substring matching across extension cards, the details page, and disable and re-enable tests.

Changes

OpenShift Local extension status checks

Layer / File(s) Summary
Update status assertions
tests/src/openshift-local-extension.spec.ts
The tests expect Installed and Disabled and use substring matching for the extension card, dependency card, details page, and checks before and after disabling or re-enabling the extension.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 84163

No actionable merge-blocking risk is identified in the test-only status updates.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies an update to end-to-end tests, which matches the pull request changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the status glow
“Installed” appears, then “Disabled” below
Substrings help the tests read clear
Through disable and enable, they persevere
The bunny hops and bounds away

Comment @coderabbitai help to get the list of available commands.

@dgolovin
dgolovin requested review from SoniaSandler and a balanced review from Copilot and removed request for Copilot October 23, 2026 21:11

@odockal odockal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@odockal
odockal merged commit d49cb89 into crc-org:main Oct 23, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants