fix: make sure the crc daemon is running before execute start (#205)" #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…daemon as the value stored could be not up to date with the environment Signed-off-by: lstocchi <[email protected]>
Signed-off-by: lstocchi <[email protected]>
Signed-off-by: lstocchi <[email protected]>
|
great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the isNeedSetup variable which is used to decide if crc has already been set up or we need to perform it. However that variable is misleading because its value is not always refreshed. By removing it we can be sure that, when needed, we exactly know if the daemon is running or not.
This fixes #205