Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove provider lifecyle #220

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: remove provider lifecyle #220

merged 1 commit into from
May 22, 2024

Conversation

lstocchi
Copy link
Contributor

This PR removes the registration of the provider lifecycle which is responsible of showing the buttons on the header of the creation page. See #203 .

The start/stop actions assigned to the provider lifecycle are the same attached to the connections lifecycle. So it looks like the registration of the provider lifecycle is actually useless.

@lstocchi lstocchi requested review from benoitf and jeffmaury May 21, 2024 07:43
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slemeur
Copy link

slemeur commented May 21, 2024

👍

@lstocchi lstocchi merged commit 12bba3d into crc-org:main May 22, 2024
3 checks passed
@lstocchi lstocchi deleted the i203_1 branch May 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants