Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump hasha from 5.2.2 to 6.0.0 #270

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 13, 2024

Bumps hasha from 5.2.2 to 6.0.0.

Release notes

Sourced from hasha's releases.

v6.0.0

Breaking

  • Require Node.js 18 6dda681
  • This package is now pure ESM. Please read this.
  • Converted the default import to named imports:
    • hashahashSync
    • hasha.asynchash
    • hasha.fromStreamhash
    • hasha.fromFilehashFile
    • hasha.fromFileSynchashFileSync
    • hasha.streamhashingStream

sindresorhus/hasha@v5.2.2...v6.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies javascript Pull requests that update Javascript code labels Aug 13, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/hasha-6.0.0 branch 3 times, most recently from 05cf5c5 to 95d8a86 Compare August 13, 2024 16:12
Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with this bump for hasha, need more time to look at it

Error: require() of ES Module /Users/eskimo/Sources/crc-extension/node_modules/hasha/index.js from /Users/eskimo/Sources/crc-extension/dist/extension.cjs not supported. Instead change the require of index.js in /Users/eskimo/Sources/crc-extension/dist/extension.cjs to a dynamic import() which is available in all CommonJS modules.
Stack trace:
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/eskimo/Sources/crc-extension/node_modules/hasha/index.js from /Users/eskimo/Sources/crc-extension/dist/extension.cjs not supported.
Instead change the require of index.js in /Users/eskimo/Sources/crc-extension/dist/extension.cjs to a dynamic import() which is available in all CommonJS modules.
    at c._load (node:electron/js2c/node_init:2:17025)
    at Function.load2 [as _load] (/Users/eskimo/Sources/podman-desktop/packages/main/dist/index.cjs:77674:29)
    at Module.<anonymous> (/Users/eskimo/Sources/crc-extension/dist/extension.cjs:40:15)

@benoitf
Copy link
Contributor

benoitf commented Aug 26, 2024

@dgolovin here is how I did that in Podman Desktop long time ago:
podman-desktop/podman-desktop@8e6debf

@dgolovin
Copy link
Contributor

I think I tried that and other ways to deal with it. It works in dev env, but does not in runtime. For example in dev mode I can use import() and it works, but I get cannot use import() outside of the module error. Will check it again after crc-extension release.

@dgolovin
Copy link
Contributor

here is how I did that in Podman Desktop long time ago:
podman-desktop/podman-desktop@8e6debf

in podman ext hasha is used only in scripts/download.ts and is not included into extension, that's why podman probably is not affected.

dependabot bot and others added 3 commits August 28, 2024 18:22
Bumps [hasha](https://github.com/sindresorhus/hasha) from 5.2.2 to 6.0.0.
- [Release notes](https://github.com/sindresorhus/hasha/releases)
- [Commits](sindresorhus/hasha@v5.2.2...v6.0.0)

---
updated-dependencies:
- dependency-name: hasha
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dgolovin dgolovin force-pushed the dependabot/npm_and_yarn/hasha-6.0.0 branch from cf99437 to 231c7b6 Compare August 29, 2024 01:22
@dgolovin dgolovin self-requested a review August 29, 2024 01:24
Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me now in local env running directly with electron.
Installing from quay.io works too.
It also works if installed from quay.io/nivologd/crc-extension:latest to PD v1.12.0

@dgolovin dgolovin merged commit 861727d into main Aug 30, 2024
3 checks passed
@dgolovin dgolovin deleted the dependabot/npm_and_yarn/hasha-6.0.0 branch August 30, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants