-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change linux default network-mode to user #4514
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d4d23de
to
42bccc9
Compare
@lilyLuLiu : Hello, Could you please provide some context on why this change is needed? |
/retest |
@lilyLuLiu About integration failure I think https://github.com/crc-org/crc/blob/main/pkg/crc/network/types.go#L65 is culprit because settings only apply if we build binary for non installer, we need to change the default here also |
8c8f346
to
1c56660
Compare
92bdef8
to
cfb029d
Compare
b383170
to
99a0ff7
Compare
c89cf80
to
e10b8d9
Compare
e10b8d9
to
6b1ce3f
Compare
/retest |
@lilyLuLiu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hi with latest CRC release including this commit crc not starting, is that expected? $ crc config view
INFO Uncompressing /home/ocp_dev/.crc/cache/crc_libvirt_4.17.14_amd64.crcbundle
With explicitly setting network mode i t works fine:- |
@karelyatin did you use
Also you need to unset following settings
|
This break your own document: https://crc.dev/docs/networking/#setting-up-on-a-remote-server |
You can still use system mode.
This documented scenario using haproxy is a semi-supported use case. If you
have a fix, please let us know or otherwise switch network mode
For the document I suggest a note about switching network mode. We do not
have an automated test in place at the moment. I see this being for
advanced use, especially as network setups can greatly differ and
complicated this.
…On Fri, Feb 21, 2025, 01:37 Shuhuan Yan ***@***.***> wrote:
This break your own document:
https://crc.dev/docs/networking/#setting-up-on-a-remote-server
It looks like in linux you change ip from 192.168.130.1 to 127.0.0.1. The
haproxy can no longer bind with bind 0.0.0.0:6443
—
Reply to this email directly, view it on GitHub
<#4514 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAOZVVKF3P2GQGK2RTEEL2QYHD3AVCNFSM6AAAAABTVRXMO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGIYTENJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: karlyan]*karlyan* left a comment (crc-org/crc#4514)
<#4514 (comment)>
This break your own document:
https://crc.dev/docs/networking/#setting-up-on-a-remote-server
It looks like in linux you change ip from 192.168.130.1 to 127.0.0.1. The
haproxy can no longer bind with bind 0.0.0.0:6443
—
Reply to this email directly, view it on GitHub
<#4514 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAOZVVKF3P2GQGK2RTEEL2QYHD3AVCNFSM6AAAAABTVRXMO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGIYTENJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I filed: crc-org/docs#26 and made a quick-fix in crc-org/docs#25 $ crc config set network-mode system |
Thanks for the response. |
We will update the document, but have no indication when this would happen. |
Currently, the Linux default network mode is system. But many issues happen due to different system situations.
For most user, user network mode already satisfied their demands. And user network mode no need to deal with complex system situations.
So after discuss, it's better to set user as default network-mode, making sure CRC works well in default.
If the user requires more functions, they can switch to system network mode.
@gbraad @praveenkumar @anjannath have agreed on this being needed.
It needs to start testing early during December.
In the worst case, we can revert before the new release in January.