Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test (machine) : add some unit tests for growing lvm size based on persistent-volume-size config option in microshift preset #4628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test (machine) : add some unit tests for growing lvm size based on persistent-volume-size config option in microshift preset #4628

wants to merge 1 commit into from
+150 −1

Conversation

rohanKanojia
Copy link
Contributor

@rohanKanojia rohanKanojia commented Feb 18, 2025 •
edited
Loading

Description

Add some unit tests for method growLVForMicroshift

Relates to: #4186, PR #4623

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

  • Replace *crcssh.Runner growLVForMicroshift method argument to receive an interface instead
  • Add unit tests using mocked implementation of ssh runner to verify various combinations of persistent-volume-size and size growth performed by the method

Testing

I've only verified that build is passing.

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rohanKanojia rohanKanojia force-pushed the pr/growLVForMicroshift-unit-tests branch from 1fbfdeb to 6e3ac93 Compare February 18, 2025 09:03
@rohanKanojia rohanKanojia marked this pull request as ready for review February 18, 2025 13:20
@rohanKanojia rohanKanojia force-pushed the pr/growLVForMicroshift-unit-tests branch 2 times, most recently from 81af69c to b762672 Compare February 18, 2025 14:49
@openshift-ci openshift-ci bot added the lgtm label Feb 28, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anjannath
anjannath reviewed Feb 28, 2025
View reviewed changes
pkg/crc/machine/start_test.go Outdated
type MockedSSHRunner struct {
mockedSSHCommandToOutputMap map[string]string
mockedSSHCommandToError map[string]error
mockedSSHCommandToArgsMap map[string]string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe remove the Map suffix from the other two struct members (mockedSSHCommandToOutputMap, mockedSSHCommandToArgsMap) as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me update it as per your suggestion.

@rohanKanojia
test (machine) : add some unit tests for growLVForMicroshift
8faa870 
+ Replace sshRunner argument in growLVForMicroshift with an interface
+ Add unit tests for abovementioned method with various combinations of persistent-volume size and disk size
+ Add unit test for validatePersistentVolumeSize

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/growLVForMicroshift-unit-tests branch from b762672 to 8faa870 Compare February 28, 2025 13:50
@openshift-ci openshift-ci bot removed the lgtm label Feb 28, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2025

@rohanKanojia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 8faa870 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjannath anjannath anjannath approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@praveenkumar praveenkumar Awaiting requested review from praveenkumar

Assignees

@anjannath anjannath

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanKanojia @anjannath