doc : Add steps to remove CRC pull secret from OS provided tools (#2572) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue2572
branch
from
d5952bc to
5e21a94
Compare
rohanKanojia
force-pushed
the
pr/issue2572
branch
from
5e21a94 to
c8377ba
Compare
praveenkumar
reviewed
Jan 8, 2025
modules/ROOT/pages/using.adoc
Outdated
| @@ -23,6 +23,66 @@ Only one preset can be active at a time. | |||
| * xref:installing.adoc#minimum-system-requirements[Minimum system requirements]. | |||
| * xref:configuring.adoc#changing-the-selected-preset[Changing the selected preset]. | |||
|
|
|||
| [id='about-pullsecrets'] | |||
| == About Pull Secrets | |||
| While starting cluster configured with {openshift} or {ushift} preset, {prod} would request you to provide a pull secret. It's required to pull some {ocp} specific container images. | |||
There was a problem hiding this comment.
Suggested change
| While starting cluster configured with {openshift} or {ushift} preset, {prod} would request you to provide a pull secret. It's required to pull some {ocp} specific container images. | |
| While starting cluster configured with {openshift} or {ushift} preset, {prod} would request you to provide a pull secret. It's required to pull container images from Red Hat container registries. |
There was a problem hiding this comment.
The sentence itself is confusing (too long?) as the "While"-statement is not correctly used here as a conjunction.
rohanKanojia
force-pushed
the
pr/issue2572
branch
from
c8377ba to
9959751
Compare
|
/assign @anjannath |
gbraad
requested changes
Jan 14, 2025
rohanKanojia
force-pushed
the
pr/issue2572
branch
from
9959751 to
27f2efd
Compare
Add steps for Windows, Linux (GNOME) and MacOS to instruct user on how to remove the CRC pull secret from credential managers on abovementioned Operating Systems. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue2572
branch
from
27f2efd to
cf78d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix crc-org/crc#2572
Add steps for Windows, Linux (GNOME), and MacOS to instruct users on removing the CRC pull secret from credential managers on the abovementioned Operating Systems.
I've tested these steps on:
For MacOS I got help from Anjan who verified steps there.