clone image before creating vm #51
Conversation
pkg/imagepullers/noop.go
Outdated
| dirs, err := env.GetMachineDirs(vmType) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
This could also be computed locally in LocalPath, I think it's the only place where it's needed. Fine with me if you prefer to keep this code in NewNoopImagePuller
pkg/imagepullers/noop.go
Outdated
| func (puller *NoopImagePuller) Download() error { | ||
| return nil | ||
| return copyFile(puller.sourceURI, puller.localPath.Path) |
There was a problem hiding this comment.
This will only work if LocalPath has been called before Download, this is currently the case but imo it's a bit unexpected.
LocalPath could be changed to return puller.localPath if it's already set, and to compute it if not. Then Download could always call LocalPath and be sure the path is correctly set.
| bufferedWriter := bufio.NewWriter(out) | ||
| defer bufferedWriter.Flush() | ||
|
|
||
| _, err = io.Copy(bufferedWriter, in) |
There was a problem hiding this comment.
We eventually want to use CloneFile on macOS with a fallback to https://github.com/containers/podman/blob/main/pkg/machine/compression/sparse_file_writer.go, and qemu-img create with a backing file on linux, but this can be done as a follow up to this PR.
This PR changes the behavior of the noopImagePuller. As this puller does not actually pull any image as it is used when an image is already in the local system, it just clones the image in a dedicated folder so that the original image does not get alterated when started by macadam. Signed-off-by: lstocchi <[email protected]>
This PR changes the behavior of the noopImagePuller. As this puller does not actually pull any image as it is used when an image is already in the local system, it just clones the image in a dedicated folder so that the original image does not get alterated when started by macadam.
it resolves https://github.com/cfergeau/macadam/issues/41 and https://github.com/cfergeau/macadam/issues/42