Enable cloud-init to inject ssh key on applehv #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with crc-org/vfkit#263 and cfergeau/podman#3 we can leverage cloud-init to inject ssh key into a rhel vm. this patch allows to set the cloudinit flag from macadam that would define if the vm should be customized by using cloud-init or the default ignition. Signed-off-by: Luca Stocchi <[email protected]>
it fixes how the local path is generated in the noop image puller. Before the name ended up having 2 dots <name>..raw Signed-off-by: Luca Stocchi <[email protected]>
cfergeau
approved these changes
Feb 27, 2025
| @@ -196,6 +196,7 @@ func initMachine(cmd *cobra.Command, args []string) error { | |||
| initOpts.DiskSize = 50 | |||
| initOpts.SSHIdentityPath = sshIdentityPath | |||
| initOpts.Username = username | |||
| initOpts.CloudInit = true // this should be calculated based on the image we want to start ?? | |||
There was a problem hiding this comment.
most likely, but we can deal with this later, I don't think it's going to be a problem to add cloudinit config to an image which does not use it.
|
Not pushing this as the go module replacement needs to be updated otherwise it won't build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with crc-org/vfkit#263 and cfergeau/podman#3 we can leverage cloud-init to inject ssh key into a rhel vm.
this patch allows to set the cloudinit flag from macadam that would define if the vm should be customized by using cloud-init or the default ignition.
This needs to be updated when cfergeau/podman#3 is merged